[DeadCode] Handle file_get_contents() only remove variable on RemoveUnusedVariableAssignRector #5162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nusedVariableAssignRector
|
Fixed 🎉 /cc @staabm |
staabm
reviewed
Oct 13, 2023
| @@ -33,6 +33,8 @@ final class PureFunctionDetector | |||
| // http | |||
| 'header', 'header_remove', 'http_response_code', 'setcookie', | |||
|
|
|||
| 'file_get_contents', | |||
There was a problem hiding this comment.
ohh nice, didn't realize we have such a list. PHPStan also has such a list.. maybe we can utilize the hasSideEffects methods of the different Reflection*-classes?
https://github.com/search?q=repo%3Aphpstan%2Fphpstan-src%20hasSideEffects&type=code
if we would trust PHPStans list, we would not need to duplicate that list in rector itself
There was a problem hiding this comment.
no, phpstan has very limited list, while psalm has more list, so it use list form psalm, if we can have script to make both tools collect more list on each other, that would be awesome :)
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8263