[AutoImport] [Renaming] Skip remove used use statement on annotation during rename + auto import when no replacement on auto import

[samsonasik]

Added test or testing skip remove use statement part of rename during auto import.

The rename annotation is allowed only on specific:

• symfony assert
• doctrine
• and serializer

see

rector-src/packages/BetterPhpDocParser/PhpDocManipulator/PhpDocClassRenamer.php

Lines 36 to 38 in d55a35b

	$this->processAssertChoiceTagValueNode($oldToNewClasses, $phpDocInfo, $hasChanged);
	$this->processDoctrineRelationTagValueNode($node, $oldToNewClasses, $phpDocInfo, $hasChanged);
	$this->processSerializerTypeTagValueNode($oldToNewClasses, $phpDocInfo, $hasChanged);

see

• MessageHandlerInterfaceToAttributeRector False positive rector-symfony#535 (comment)

on auto import, the process is overlapped, which annotation not renamed, but use statement removed during auto import.

[samsonasik]

@jambonfarci @stefantalen it fixed by skip remove use statement when no replacement during auto import cd3ee41 🎉

[samsonasik]

on auto import enabled, when nothing to replace, the removing use statement should not happen, as it cause invalid removal on rename process.

[samsonasik]

the re-index to set name importing and use adding post rector first is on purpose to know that auto import collecting the statements that need to be added, which class renaming depends.

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;)

[TomasVotruba]

👍

[samsonasik]

@TomasVotruba @jambonfarci @stefantalen I tested in laminas-servicemanager-migration usage on auto import usage, it seems cause error:

There were 5 failures:

1) LaminasTest\ServiceManager\Migration\Rector\RenameClassRector\AutoImportTest::test with data set #0 ('/Users/samsonasik/www/laminas...hp.inc')
Failed on fixture file "factory_invoke_typehint.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 namespace LaminasTest\ServiceManager\Migration\Rector\RenameClassRector\FixtureAutoImport;
 
-use Psr\Container\ContainerInterface;
+use Interop\Container\ContainerInterface;
 
 class FactoryInvokeTypehint
 {
-    public function __invoke(ContainerInterface $container)
+    public function __invoke(\Psr\Container\ContainerInterface $container)

which auto import should be allowed, this definitely need rework, I will check if the original allow change SpacelessPhpDocTagNode on PR:

• [Renaming] Handle rename annotation with auto import on RenameClassRector #5164

can be solution, but on consequency, rector-symfony list need update for AnnotationToAttribute to use targetted:

Symfony\Component\Security\Http\Attribute\IsGranted

instead of

Sensio\Bundle\FrameworkExtraBundle\Configuration\IsGranted

https://github.com/rectorphp/rector-symfony/blob/873458ca73a73f9becd1680963a347bbcb8e5f43/config/sets/sensiolabs/annotations-to-attributes.php#L14

Give me time :)

[samsonasik]

Reverting at #5179