[AutoImport] Handle multiple @\ after GenericTagValueNode #5277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
force-pushed
the
after-generic
branch
from
0fbed18
to
0c7557f
Compare
samsonasik
force-pushed
the
after-generic
branch
2 times, most recently
from
d2e3928
to
c023cba
Compare
|
Closing for now as currently skipped. |
samsonasik
force-pushed
the
after-generic
branch
from
c023cba
to
8440d55
Compare
|
Re-open, handled with set attribute to marking |
samsonasik
commented
Nov 25, 2023
| @@ -22,7 +22,7 @@ public function __toString(): string | |||
| { | |||
| $value = ''; | |||
|
|
|||
| if ($this->key !== null) { | |||
| if ($this->key !== null && ! is_numeric($this->key)) { | |||
There was a problem hiding this comment.
this is required as the __toString() cause invalid change 0=@OA conversion on generic:
* @OA\Property(
* type="array",
* @OA\Items(ref=@Model(type=TestItem::class))
* )There was a problem hiding this comment.
updated with other usage with is_int($key) to make consistent at PR:
samsonasik
commented
Nov 25, 2023
| class TwoRoutesAfterGeneric | ||
| { | ||
| /** | ||
| * @OA\Property(type="array", @OA\Items(ref=@Model(type=TestItem::class))) |
There was a problem hiding this comment.
it become single line due to require re-print after it changed after.
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback ot test ;) |
This was referenced Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TomasVotruba continue of PR:
this handle multiple
@\afterGenericTagValueNode