Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stub] Add Symfony Request stub to fix downgrade symfony/console on downgrading symfony/console:6.4 #5303

Closed
wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 30, 2023

@TomasVotruba here continue of PR:

I added a stub file stubs/Symfony/Component/HttpFoundation/Request.php to allow downgrade symfony console:6.4 and rollback change on symfony/console dependency on 6.4.

Also add test to prove it.

Fixes rectorphp/rector#8333

@samsonasik
Copy link
Member Author

@TomasVotruba it seems there are unrelated error tests, seems due to latest dependencies update, which unrelated to symfony/console:

There were 14 failures:

1) Rector\Core\Tests\Issues\ConstructorPromoAnnotationToAttribute\ConstructorPromoAnnotationToAttributeTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class TestResponse
 {
-    public function __construct(
-        /**
-         * @OA\Property(
-         *     type="array",
-         *     @OA\Items(ref=@Model(type=TestItem::class))
-         * )
-         */
-        public array $items = []
-    )
+    /**
+     * @OA\Property(
+     *     type="array",
+     *     @OA\Items(ref=@Model(type=TestItem::class))
+     * )
+     */
+    public array $items;
+
+    public function __construct(array $items = [])
     {
+        $this->items = $items;
     }
 }
 ?>

@samsonasik
Copy link
Member Author

@TomasVotruba ok, changing back to main branch seems solve it, so it definatelly some dependency issue or definition Request stub cause the error.

@samsonasik samsonasik marked this pull request as draft November 30, 2023 16:48
@samsonasik
Copy link
Member Author

Closing for now, the CliRequest is under Debug namespace in symfony-console, I guess we can just exclude from the parallel-lint command.

@samsonasik samsonasik closed this Nov 30, 2023
@samsonasik samsonasik deleted the add-failing-fixture branch November 30, 2023 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant