[PHP81] Skip after is_string on object call on NullToStrictStringFuncCallArgRector #5572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed 🎉 /cc @OskarStark |
OskarStark
reviewed
Feb 7, 2024
|
|
||
| final class SkipAfterIsStringOnObjectCall | ||
| { | ||
| public ?string $stringNull = 'foo'; |
There was a problem hiding this comment.
does this also work with a method instead of a property?
There was a problem hiding this comment.
should be work if native type defined, the NullToStrictStringFuncCallArgRector is to work with safe change,
- with
@param string, it means already string, to avoid too many change, - with native type, it means already string as well.
There was a problem hiding this comment.
@OskarStark you can try on https://getrector.com/demo whether you find another case :)
shortly after a PR is merged the demo is updated
|
All checks have passed 🎉 @TomasVotruba I am merging it;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rectorphp/rector#8468