fix: Strip left spaces from opening tags when comparing output for changes #5701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anges Spaces removed from before opening tags in both the original and new content. Fixes: rectorphp/rector#8533
samsonasik
reviewed
Mar 8, 2024
samsonasik
reviewed
Mar 8, 2024
samsonasik
reviewed
Mar 8, 2024
Co-authored-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
…re regex first as it can be a little slower
|
Hi @samsonasik |
samsonasik
reviewed
Mar 8, 2024
|
Thanks @samsonasik, just pushed a fix for that. |
|
@TomasVotruba let's merge it, thank you @stilliard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for changes, spaces can be temp removed from before the opening PHP tags in both the original and new content to cut down on whitespace only changes.
Fixes: rectorphp/rector#8533
Should be safe & unit tests pass, however I could wrap this in a config check and make it an opt in thing to ignore whitespace before opening tags if needed?
Let me know what you think, thanks.