composer-dependency-analyser: fix dependency issues #5777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janedbal
commented
Mar 27, 2024
samsonasik
reviewed
Mar 27, 2024
samsonasik
reviewed
Mar 27, 2024
samsonasik
reviewed
Mar 27, 2024
samsonasik
reviewed
Mar 27, 2024
rules/TypeDeclaration/NodeAnalyzer/AutowiredClassMethodOrPropertyAnalyzer.php
Outdated
Show resolved
Hide resolved
janedbal
force-pushed
the
composer-dependency-analyser
branch
from
cb4957f
to
a928a0e
Compare
samsonasik
approved these changes
Apr 4, 2024
|
Thank you @janedbal |
|
Thank you for all the extensive effort to make this pass @janedbal 🙏 Great package 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tested this repository with composer-dependency-analyser and it found some issues.
I tried fixing those, but you may guide me towards better direction in some cases. Here is the original report:
So I fixed those via:
symfony/service-contracts- used string usage just like the Nette one beside thatsymfony/yaml- added as dev dependency as it is used in testsnette/robot-loader- moved torequireas it is used in utilsrector/rector-downgrade-php- markedbuild/configas prod path for the analyser (is that correct?)fidry/cpu-core-counter- removed, it really looks unused (wondering why composer-unused you have in CI didnt find this)react/promise- removed, felt unused tooLet me know if you want to adjust any of that. I also added this tool to CI to prevent similar issues in future.