[DeadCode] Clean up TypeHasher on Union Type #5792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
commented
Apr 3, 2024
| @@ -23,7 +23,7 @@ namespace Rector\Tests\CodeQuality\Rector\Class_\CompleteDynamicPropertiesRector | |||
| class MultipleTypes | |||
| { | |||
| /** | |||
| * @var int|string|bool | |||
| * @var bool|int|string | |||
There was a problem hiding this comment.
this is sorted docblock by phpstan, previous clone and map cause overlapped types and not stable definition.
|
All checks have passed 🎉 @TomasVotruba I am merging it to have faster feedback to test ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #5684
For clean up
TypeHasheron Union type, and specific on dead param, keep markSomeClass|SomeInterfaceas not dead param as before with Union vs FullyQualified check.