Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Php71] Add MultiDimensionalArrayToArrayDestructRector #6031

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithMultidimensionalAssociativeArray
{
/**
* @param array<int, array{id: int, name: string}> $users
*/
public function run(array $users)
{
$translations = [
'name' => 'Name',
];

foreach ($users as $user) {
echo $user['id'];
echo sprintf('%s: %s', $translations['name'], $user['name']);
}
}
}

?>
-----
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithMultidimensionalAssociativeArray
{
/**
* @param array<int, array{id: int, name: string}> $users
*/
public function run(array $users)
{
$translations = [
'name' => 'Name',
];

foreach ($users as ['id' => $id, 'name' => $name]) {
echo $id;
echo sprintf('%s: %s', $translations['name'], $name);
}
}
}

?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithNestedMultidimensionalAssociativeArrayVariableUsed
{
/**
* @param array<int, array{id: int, name: string, email: list<string>}> $users
*/
public function run(array $users)
{
foreach ($users as $user) {
echo $user['id'];
echo sprintf('Name: %s', $user['name']);

foreach ($user['email'] as $email) {
echo $email;
}
}
}
}

?>
-----
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithNestedMultidimensionalAssociativeArrayVariableUsed
{
/**
* @param array<int, array{id: int, name: string, email: list<string>}> $users
*/
public function run(array $users)
{
foreach ($users as ['id' => $id, 'name' => $name, 'email' => $email1]) {
echo $id;
echo sprintf('Name: %s', $name);

foreach ($email1 as $email) {
echo $email;
}
}
}
}

?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithNestedMultidimensionalAssociativeArray
{
/**
* @param array<int, array{id: int, name: string, emails: list<string>}> $users
*/
public function run(array $users)
{
foreach ($users as $user) {
echo $user['id'];
echo sprintf('Name: %s', $user['name']);

foreach ($user['emails'] as $email) {
echo $email;
}
}
}
}

?>
-----
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class ForeachWithNestedMultidimensionalAssociativeArray
{
/**
* @param array<int, array{id: int, name: string, emails: list<string>}> $users
*/
public function run(array $users)
{
foreach ($users as ['id' => $id, 'name' => $name, 'emails' => $emails]) {
echo $id;
echo sprintf('Name: %s', $name);

foreach ($emails as $email) {
echo $email;
}
}
}
}

?>
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class SkipForeachWithMultidimensionalAssociativeAndNumericArray
{
/**
* @param array<int, array{0: int, id: int, name: string}> $users
*/
public function run(array $users)
{
foreach ($users as $user) {
echo $user[0];
echo $user['id'];
echo sprintf('Name: %s', $user['name']);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class SkipForeachWithMultidimensionalIndexedArray
{
/**
* @param array<int, array{0: int, 1: string}> $users
*/
public function run(array $users)
{
foreach ($users as $user) {
echo $user[0];
echo sprintf('Name: %s', $user[0]);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
<?php

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector\Fixture;

final class SkipForeachWithNonMultiDimensionalArray
{
/**
* @param array{id: int, name: string} $userFields
*/
public function run(array $userFields)
{
$translations = [
'id' => 'ID',
'name' => 'Name',
];

foreach ($userFields as $key => $userField) {
echo sprintf('%s: %s', $translations[$key], $userField);
}
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
<?php

declare(strict_types=1);

namespace Rector\Tests\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector;

use Iterator;
use PHPUnit\Framework\Attributes\DataProvider;
use Rector\Testing\PHPUnit\AbstractRectorTestCase;

final class MultiDimensionalArrayToArrayDestructRectorTest extends AbstractRectorTestCase
{
#[DataProvider('provideData')]
public function test(string $filePath): void
{
$this->doTestFile($filePath);
}

public static function provideData(): Iterator
{
return self::yieldFilesFromDirectory(__DIR__ . '/Fixture');
}

public function provideConfigFilePath(): string
{
return __DIR__ . '/config/configured_rule.php';
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?php

declare(strict_types=1);

use Rector\CodingStyle\Rector\Foreach\MultiDimensionalArrayToArrayDestructRector;
use Rector\Config\RectorConfig;

return RectorConfig::configure()
->withRules([MultiDimensionalArrayToArrayDestructRector::class]);
Loading