Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add code as a named argument #6062

Merged
merged 1 commit into from
Jun 27, 2024
Merged

fix: Add code as a named argument #6062

merged 1 commit into from
Jun 27, 2024

Conversation

nikolicaleksa
Copy link
Contributor

@nikolicaleksa nikolicaleksa commented Jun 27, 2024 •
edited
Loading

@samsonasik
Copy link
Member

you can update PR description with

Fixes https://github.com/rectorphp/rector/issues/8698

to automatically close the issue when PR got merged.

@TomasVotruba
Copy link
Member

How would this work on PHP 7.4?

@nikolicaleksa
Copy link
Contributor Author

How would this work on PHP 7.4?

I think it should not be a problem as we are not always adding the named parameter, it's based on condition $shouldUseNamedArguments = $messageArgument->name !== null; which for PHP 7.4 would always evaluate to false

@TomasVotruba
Copy link
Member

I see, looks good then 👍

@TomasVotruba TomasVotruba merged commit 4841e57 into rectorphp:main Jun 27, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nikolicaleksa @samsonasik @TomasVotruba