[Php74] Add CurlyToSquareBracketArrayStringRector #858
Conversation
samsonasik
force-pushed
the
add-curly-to-square
branch
from
13b365d
to
faa2f4c
Compare
|
All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
force-pushed
the
add-curly-to-square
branch
from
389edf1
to
beb61b7
Compare
|
rebased. |
| public function refactor(Node $node): ArrayDimFetch | ||
| { | ||
| $node->setAttribute(AttributeKey::ORIGINAL_NODE, null); | ||
| return $node; |
There was a problem hiding this comment.
This will lead to reprint of every node regardless the feature is present
There should be some check to verify the syntax change is needed.
There was a problem hiding this comment.
any way to check that? because printing check first is always return square one.
There was a problem hiding this comment.
That should not be hidden in the printer IMO.
Maybe using "kind" attribute as array has?
Check for the trailing comma rule, there is some logic with tokens too.
There was a problem hiding this comment.
I will try, probably something like FollowedByCommaAnalyzer
There was a problem hiding this comment.
implemented 🎉 I added FollowedByCurlyBracketAnalyzer service for it https://github.com/rectorphp/rector-src/pull/858/files#diff-9b13ecfac64fb2e2e12b342348070427427b0d5ac27dd0a72774869535003034
There was a problem hiding this comment.
Thanks!
Could you add comment to original node to null? Just so it's clear what is the goal of it
There was a problem hiding this comment.
I added the comment e1e8472, the purpose is to re-draw the ArrayDimFetch to use [] bracket
samsonasik
force-pushed
the
add-curly-to-square
branch
from
d4fb876
to
eb1afbf
Compare
samsonasik
force-pushed
the
add-curly-to-square
branch
from
61ff814
to
31bc052
Compare
|
All checks have passed 🎉 @TomasVotruba I think it is ready. |
No description provided.