Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GetParameterToConstructorInjectionRector does not handle Commands #60

Closed
Bilge opened this issue Nov 8, 2021 · 2 comments
Closed

GetParameterToConstructorInjectionRector does not handle Commands #60

Bilge opened this issue Nov 8, 2021 · 2 comments
Assignees
@samsonasik

Comments

@Bilge
Copy link

Bilge commented Nov 8, 2021

It seems GetParameterToConstructorInjectionRector is hard-coded to only deal with Controllers (of type Controller or AbstractController), but there once existed ContainerAwareCommand also, for which parameter injections may also be needed, in older code bases.
@TomasVotruba
Copy link
Member

Hi, thanks for reporting. Could you extend the rule to handle other types too?

@TomasVotruba
Copy link
Member

Closing as there is no getParameter() in ContainerAwareCommand - symfony/symfony@744bf0e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samsonasik samsonasik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samsonasik @Bilge @TomasVotruba