Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Symfony62] Replace attributes #264 #265

Merged
merged 1 commit into from
Nov 2, 2022
Merged

Conversation

JohJohan
Copy link
Contributor

@JohJohan JohJohan commented Nov 2, 2022

Replace IsGranted, Cache and Template

@JohJohan
Copy link
Contributor Author

JohJohan commented Nov 2, 2022

I didn't do ParamConverter as that is a bit more work with the mapping see https://symfony.com/blog/new-in-symfony-6-2-built-in-cache-security-template-and-doctrine-attributes maybe that can be a different ticket?

@JohJohan
Copy link
Contributor Author

JohJohan commented Nov 2, 2022

If #266 is merged i need to update

$rectorConfig->sets([SymfonySetList::SYMFONY_62, SymfonyLevelSetList::UP_TO_SYMFONY_60]);

@TomasVotruba
Copy link
Member

Thank you 👏

@TomasVotruba TomasVotruba merged commit 56b183d into rectorphp:main Nov 2, 2022
samsonasik pushed a commit to JohJohan/rector-symfony that referenced this pull request Nov 23, 2022
Co-authored-by: johan <johan@adivare.nl>
@JohJohan JohJohan deleted the 264 branch November 23, 2022 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants