Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with privatesCaller not found #276

Merged
merged 1 commit into from Nov 19, 2022

Conversation

PhilippSchreiber
Copy link
Contributor

@PhilippSchreiber PhilippSchreiber commented Nov 19, 2022

@samsonasik
Copy link
Member

@TomasVotruba The MethodCallRenameWithArrayKey error seems due to the class removed the MethodCallRenameWithArrayKey class on your PR:

should the class and its usage be reverted ?

@samsonasik
Copy link
Member

@TomasVotruba this got class MethodCallRenameWithArrayKey not found error;

new MethodCallRenameWithArrayKey(

@TomasVotruba
Copy link
Member

@samsonasik That's intersting... it should fail on rector-src then. We probably need to run PHPStan in CI tests there too.
I'll revert, thanks

@TomasVotruba TomasVotruba merged commit 0a9fcc8 into rectorphp:main Nov 19, 2022
@TomasVotruba
Copy link
Member

Thank you @PhilippSchreiber

samsonasik pushed a commit to JohJohan/rector-symfony that referenced this pull request Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants