[ErrorNamesPropertyToConstantRector] add new rule to fix #280

[JohJohan]

No description provided.

[johanadivare]

Im not sure what the best way to find if property $errorNames is used. I saw we have one rector rule (JMSInjectPropertyToConstructorInjectionRector) to change properties but dont think that is usefull for this case see the replace fixture for example.

[stefantalen]

Shouldn't this be PhpParser\Node\Expr\StaticPropertyFetch?

[stefantalen]

I'd use Rector\Core\Reflection\ReflectionResolver to check if $node->class is a subclass of Symfony\Component\Validator\Constraint 🙂

[johanadivare]

I'd use Rector\Core\Reflection\ReflectionResolver to check if $node->class is a subclass of Symfony\Component\Validator\Constraint slightly_smiling_face

@stefantalen thanks that was very helpful

[johanadivare]

I dont know why https://github.com/rectorphp/rector-symfony/actions/runs/4281227323/jobs/7453990047 is failing. I did composer update and ran vendor/bin/rector --clear-cache so rector shouldn't be failing.

On the other hand the rector always fails with this message: Error: '{brancName}' branch not found. it would be nice to see the actual rector output is that possible? In this case i would then see what is wrong.

[stefantalen]

Try composer fix-cs 😉 (If you look at the action, the ECS check is failing because it wants to change your code)

[johanadivare]

Try composer fix-cs wink (If you look at the action, the ECS check is failing because it wants to change your code)

Yes thank you :) i now see i can also open the logs above.

[johanadivare]

@samsonasik can you do a cr?

[TomasVotruba]

We'll need a rebase here.

[TomasVotruba]

Suggested change

	if ($this->nodeNameResolver->getName($node->name) !== 'errorNames') {
	if (! $this->nodeNameResolver->isName($node->name, 'errorNames')) {

[TomasVotruba]

It's look very good!
Please rebase, fix one detail and ready to merge 👍

[samsonasik]

You can use:

ParametersAcceptorSelector::combineAcceptors(
$extendedMethodReflection->getVariants())

That ensure multi variants is supported.

[johanadivare]

Done

[johanadivare]

@TomasVotruba and @samsonasik made the requested changes and pipeline passes can you cr again

[TomasVotruba]

Looks good to me 👍

@samsonasik Feel free to merge when ready for you 🙏

[samsonasik]

Thank you @johanadivare