Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Symfony62Test to cover to not remove existing use statement on rename class #375

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

samsonasik
Copy link
Member

This is to cover make consistent to not remove unused use when no auto import (replace) and no $rectorConfig->removeUnusedImports() used, see no namespace vs namespaced class below:

Without namespace (got removed) : https://getrector.com/demo/1fe1232a-4741-4564-b225-8f0822338071
With namespace (unused use is kept) : https://getrector.com/demo/b4de0818-8ca3-496b-92c7-6f54e9ffd4cd

on PR:

@samsonasik samsonasik closed this Mar 6, 2023
@samsonasik samsonasik reopened this Mar 6, 2023
@samsonasik samsonasik closed this Mar 6, 2023
@samsonasik samsonasik reopened this Mar 6, 2023
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba I think it is ready.

@TomasVotruba TomasVotruba merged commit c527ff3 into main Mar 6, 2023
@TomasVotruba TomasVotruba deleted the update-test branch March 6, 2023 11:27
@TomasVotruba
Copy link
Member

TomasVotruba commented Mar 6, 2023

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants