Drop triun/longest-common-substring dependency #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
phpstan reports
but I don't see a single method which does not declare its return type? |
staabm
commented
Mar 14, 2023
| @@ -37,6 +37,9 @@ parameters: | |||
| message: '#Instead of "instanceof/is_a\(\)" use ReflectionProvider service or "\(new ObjectType\(<desired_type\>\)\)\-\>isSuperTypeOf\(<element_type\>\)" for static reflection to work#' | |||
| path: src/ValueObjectFactory/ServiceMapFactory.php | |||
|
|
|||
| - '#Cognitive complexity for "Rector\\Symfony\\Rector\\Closure\\MinimalSharedStringSolver\:\:solve\(\)" is (.*?), keep it under 10#' | |||
There was a problem hiding this comment.
I decided to ignore this error, since I don't want to fiddle in this "external" code and introduce bugs since we don't know all the details
samsonasik
reviewed
Mar 14, 2023
samsonasik
reviewed
Mar 14, 2023
samsonasik
reviewed
Mar 14, 2023
staabm
commented
Mar 14, 2023
Comment on lines
-109
to
-111
| if (! is_string($sharedNamespace)) { | ||
| return null; | ||
| } |
There was a problem hiding this comment.
since the MinimalSharedStringSolver no longer implements the Solver interface, we were able to declare more specific return types which also means this case - which was never taken, as null could technically not be returned - can be dropped.
samsonasik
approved these changes
Mar 14, 2023
|
Thank you @staabm |
| /** | ||
| * Class Solver copied from https://github.com/Triun/PHP-Longest-Common-Substring | ||
| */ | ||
| final class MinimalSharedStringSolver |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes rectorphp/rector#7832