Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid ContainerGetToConstructorInjectionRector on TestCase classes #66

Merged
merged 6 commits into from
Nov 14, 2021

Conversation

TomasVotruba
Copy link
Member

@TomasVotruba TomasVotruba commented Nov 14, 2021

Closes #65

Closes #64

@TomasVotruba TomasVotruba changed the title patch 2 Avoid ContainerGetToConstructorInjectionRector on TestCase classes Nov 14, 2021
@TomasVotruba
Copy link
Member Author

@alexander-schranz Your solution was correct 👍 Just in this case it's better to use PHPStan scope instead of class_parents. The PHPStan failing CI should suggest that.

@TomasVotruba TomasVotruba merged commit 5a699f0 into main Nov 14, 2021
@TomasVotruba TomasVotruba deleted the patch-2 branch November 14, 2021 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ContainerGetToConstructorInjectionRector should ignore PHPUnit or KernelTestCase classes
2 participants