Cleanup (#1270)

rectorphp · Nov 18, 2021 · 1a4c5fb · 1a4c5fb
1 parent 78829b3
commit 1a4c5fb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php b/packages/PhpAttribute/Printer/PhpAttributeGroupFactory.php
@@ -18,6 +18,7 @@
 use Rector\Php80\ValueObject\AnnotationToAttribute;
 use Rector\PhpAttribute\NodeAnalyzer\NamedArgumentsResolver;
 use Rector\PhpAttribute\Value\ValueNormalizer;
+use Webmozart\Assert\Assert;
 
 /**
  * @see \Rector\Tests\PhpAttribute\Printer\PhpAttributeGroupFactoryTest
@@ -145,6 +146,8 @@ private function normalizeStringDoubleQuote(Expr $expr): void
      */
     private function completeNamedArguments(array $args, array $argumentNames): void
     {
+        Assert::allIsAOf($args, Arg::class);
+
         foreach ($args as $key => $arg) {
             $argumentName = $argumentNames[$key] ?? null;
             if ($argumentName === null) {

diff --git a/rules/Php80/Rector/Class_/AnnotationToAttributeRector.php b/rules/Php80/Rector/Class_/AnnotationToAttributeRector.php
@@ -223,6 +223,10 @@ private function processGenericTags(PhpDocInfo $phpDocInfo): array
      */
     private function processDoctrineAnnotationClasses(PhpDocInfo $phpDocInfo): array
     {
+        if ($phpDocInfo->getPhpDocNode()->children === []) {
+            return [];
+        }
+
         $doctrineTagAndAnnotationToAttributes = [];
 
         $phpDocNodeTraverser = new PhpDocNodeTraverser();