drop redundant interface and factory

compiler/bin/compile

@@ -4,18 +4,14 @@
 declare(strict_types = 1);
 
 use Rector\Compiler\Console\CompileCommand;
-use Rector\Compiler\Process\ProcessFactory;
 use Symfony\Component\Console\Application;
 
 require_once __DIR__ . '/../vendor/autoload.php';
 
-$compileCommand = new CompileCommand(
-	new ProcessFactory(),
-	__DIR__ . '/../build',
-	__DIR__ . '/../..'
-);
+$compileCommand = new CompileCommand(__DIR__ . '/../build', __DIR__ . '/../..');
 
 /** @var Application $application */
+
 $application = new Application();
 $application->add($compileCommand);
 $application->setDefaultCommand($compileCommand->getName(), true);

compiler/src/Console/CompileCommand.php

@@ -6,6 +6,7 @@
 
 use Nette\Utils\FileSystem as NetteFileSystem;
 use Nette\Utils\Json;
+use Rector\Compiler\Process\InstantlyRunningSymfonyProcess;
 use Rector\Compiler\Process\ProcessFactory;
 use Symfony\Component\Console\Command\Command;
 use Symfony\Component\Console\Input\InputInterface;
@@ -17,21 +18,11 @@
  */
 final class CompileCommand extends Command
 {
-    /**
-     * @var string
-     */
-    public const NAME = 'rector:compile';
-
     /**
      * @var Filesystem
      */
     private $filesystem;
 
-    /**
-     * @var ProcessFactory
-     */
-    private $processFactory;
-
     /**
      * @var string
      */
@@ -47,37 +38,35 @@ final class CompileCommand extends Command
      */
     private $originalComposerJsonFileContent;
 
-    public function __construct(ProcessFactory $processFactory, string $dataDir, string $buildDir)
+    public function __construct(string $dataDir, string $buildDir)
     {
         parent::__construct();
         $this->filesystem = new Filesystem();
-        $this->processFactory = $processFactory;
         $this->dataDir = $dataDir;
         $this->buildDir = $buildDir;
     }
 
     protected function configure(): void
     {
-        $this->setName(self::NAME);
+        $this->setName('rector:compile');
         $this->setDescription('Compile prefixed rector.phar');
     }
 
     protected function execute(InputInterface $input, OutputInterface $output): int
     {
-        $this->processFactory->setOutput($output);
-
         $composerJsonFile = $this->buildDir . '/composer.json';
 
         $this->fixComposerJson($composerJsonFile);
         // @see https://github.com/dotherightthing/wpdtrt-plugin-boilerplate/issues/52
-        $this->processFactory->create(
+        new InstantlyRunningSymfonyProcess(
             ['composer', 'update', '--no-dev', '--prefer-dist', '--no-interaction', '--classmap-authoritative'],
-            $this->buildDir
+            $this->buildDir,
+            $output
         );
 
         // the '--no-parallel' is needed, so "scoper.php.inc" can "require __DIR__ ./vendor/autoload.php"
         // and "Nette\Neon\Neon" class can be used there
-        $this->processFactory->create(['php', 'box.phar', 'compile', '--no-parallel'], $this->dataDir);
+        new InstantlyRunningSymfonyProcess(['php', 'box.phar', 'compile', '--no-parallel'], $this->dataDir, $output);
 
         $this->restoreComposerJson($composerJsonFile);
 

compiler/src/Process/InstantlyRunningSymfonyProcess.php

@@ -0,0 +1,23 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Rector\Compiler\Process;
+
+use Symfony\Component\Console\Output\OutputInterface;
+use Symfony\Component\Process\Process;
+
+final class InstantlyRunningSymfonyProcess
+{
+    /**
+     * @param string[] $command
+     */
+    public function __construct(array $command, string $cwd, OutputInterface $output)
+    {
+        $process = new Process($command, $cwd, null, null, null);
+
+        $process->mustRun(static function (string $type, string $buffer) use ($output): void {
+            $output->write($buffer);
+        });
+    }
+}

compiler/src/Process/ProcessFactory.php

@@ -4,32 +4,15 @@
 
 namespace Rector\Compiler\Process;
 
-use Rector\Compiler\Contract\Process\ProcessInterface;
-use Symfony\Component\Console\Output\NullOutput;
 use Symfony\Component\Console\Output\OutputInterface;
 
 final class ProcessFactory
 {
-    /**
-     * @var OutputInterface
-     */
-    private $output;
-
-    public function __construct()
-    {
-        $this->output = new NullOutput();
-    }
-
     /**
      * @param string[] $command
      */
-    public function create(array $command, string $cwd): ProcessInterface
-    {
-        return new SymfonyProcess($command, $cwd, $this->output);
-    }
-
-    public function setOutput(OutputInterface $output): void
+    public function create(array $command, string $cwd, OutputInterface $output): InstantlyRunningSymfonyProcess
     {
-        $this->output = $output;
+        return new InstantlyRunningSymfonyProcess($command, $cwd, $output);
     }
 }