Skip to content

Commit

Permalink
Updated Rector to commit 70fea54e77ffd186e41540d2b36c5362b073fbc4
Browse files Browse the repository at this point in the history
rectorphp/rector-src@70fea54 [DeadCode] Add TargetRemoveClassMethodRector (#3240)
  • Loading branch information
TomasVotruba committed Dec 22, 2022
1 parent d72c810 commit 96d8a22
Show file tree
Hide file tree
Showing 8 changed files with 158 additions and 14 deletions.
38 changes: 36 additions & 2 deletions docs/rector_rules_overview.md
@@ -1,4 +1,4 @@
# 416 Rules Overview
# 417 Rules Overview

<br>

Expand All @@ -12,7 +12,7 @@

- [Compatibility](#compatibility) (1)

- [DeadCode](#deadcode) (47)
- [DeadCode](#deadcode) (48)

- [DependencyInjection](#dependencyinjection) (2)

Expand Down Expand Up @@ -3664,6 +3664,40 @@ Removes unneeded `$value` = `$value` assigns

<br>

### TargetRemoveClassMethodRector

Remove defined class method

:wrench: **configure it!**

- class: [`Rector\DeadCode\Rector\Class_\TargetRemoveClassMethodRector`](../rules/DeadCode/Rector/Class_/TargetRemoveClassMethodRector.php)

```php
use Rector\Config\RectorConfig;
use Rector\DeadCode\Rector\Class_\TargetRemoveClassMethodRector;
use Rector\DeadCode\ValueObject\TargetRemoveClassMethod;

return static function (RectorConfig $rectorConfig): void {
$rectorConfig->ruleWithConfiguration(
TargetRemoveClassMethodRector::class,
[new TargetRemoveClassMethod('SomeClass', 'run')]
);
};
```


```diff
class SomeClass
{
- public function run()
- {
- }
}
```

<br>

### TernaryToBooleanOrFalseToBooleanAndRector

Change ternary of bool : false to && bool
Expand Down
75 changes: 75 additions & 0 deletions rules/DeadCode/Rector/Class_/TargetRemoveClassMethodRector.php
@@ -0,0 +1,75 @@
<?php

declare (strict_types=1);
namespace Rector\DeadCode\Rector\Class_;

use PhpParser\Node;
use PhpParser\Node\Stmt\Class_;
use PhpParser\Node\Stmt\ClassMethod;
use Rector\Core\Contract\Rector\ConfigurableRectorInterface;
use Rector\Core\Rector\AbstractRector;
use Rector\DeadCode\ValueObject\TargetRemoveClassMethod;
use Symplify\RuleDocGenerator\ValueObject\CodeSample\ConfiguredCodeSample;
use Symplify\RuleDocGenerator\ValueObject\RuleDefinition;
use RectorPrefix202212\Webmozart\Assert\Assert;
/**
* @see \Rector\Tests\DeadCode\Rector\Class_\TargetRemoveClassMethodRector\TargetRemoveClassMethodRectorTest
*/
final class TargetRemoveClassMethodRector extends AbstractRector implements ConfigurableRectorInterface
{
/**
* @var TargetRemoveClassMethod[]
*/
private $targetRemoveClassMethods = [];
public function getRuleDefinition() : RuleDefinition
{
return new RuleDefinition('Remove defined class method', [new ConfiguredCodeSample(<<<'CODE_SAMPLE'
class SomeClass
{
public function run()
{
}
}
CODE_SAMPLE
, <<<'CODE_SAMPLE'
class SomeClass
{
}
CODE_SAMPLE
, [new TargetRemoveClassMethod('SomeClass', 'run')])]);
}
public function getNodeTypes() : array
{
return [Class_::class];
}
/**
* @param Class_ $node
*/
public function refactor(Node $node) : ?Node
{
if ($node->isAnonymous()) {
return null;
}
foreach ($this->targetRemoveClassMethods as $targetRemoveClassMethod) {
if (!$this->isName($node, $targetRemoveClassMethod->getClassName())) {
continue;
}
$classMethod = $node->getMethod($targetRemoveClassMethod->getMethodName());
if (!$classMethod instanceof ClassMethod) {
continue;
}
$this->removeNode($classMethod);
return null;
}
return null;
}
/**
* @param mixed[] $configuration
*/
public function configure(array $configuration) : void
{
Assert::notEmpty($configuration);
Assert::allIsInstanceOf($configuration, TargetRemoveClassMethod::class);
$this->targetRemoveClassMethods = $configuration;
}
}
31 changes: 31 additions & 0 deletions rules/DeadCode/ValueObject/TargetRemoveClassMethod.php
@@ -0,0 +1,31 @@
<?php

declare (strict_types=1);
namespace Rector\DeadCode\ValueObject;

final class TargetRemoveClassMethod
{
/**
* @readonly
* @var string
*/
private $className;
/**
* @readonly
* @var string
*/
private $methodName;
public function __construct(string $className, string $methodName)
{
$this->className = $className;
$this->methodName = $methodName;
}
public function getClassName() : string
{
return $this->className;
}
public function getMethodName() : string
{
return $this->methodName;
}
}
4 changes: 2 additions & 2 deletions src/Application/VersionResolver.php
Expand Up @@ -17,12 +17,12 @@ final class VersionResolver
* @api
* @var string
*/
public const PACKAGE_VERSION = 'c78e255cf9cb17cedead84ff8a54f421f563942d';
public const PACKAGE_VERSION = '70fea54e77ffd186e41540d2b36c5362b073fbc4';
/**
* @api
* @var string
*/
public const RELEASE_DATE = '2022-12-22 16:49:11';
public const RELEASE_DATE = '2022-12-22 18:02:44';
/**
* @var int
*/
Expand Down
2 changes: 1 addition & 1 deletion vendor/autoload.php
Expand Up @@ -22,4 +22,4 @@

require_once __DIR__ . '/composer/autoload_real.php';

return ComposerAutoloaderInit099468b8f0503dfa63adfbd0082c61cf::getLoader();
return ComposerAutoloaderInitf4223b92917874ab1dbad62f3f4ea2d4::getLoader();
2 changes: 2 additions & 0 deletions vendor/composer/autoload_classmap.php
Expand Up @@ -1566,6 +1566,7 @@
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUnusedPromotedPropertyRector' => $baseDir . '/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php',
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUselessParamTagRector' => $baseDir . '/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php',
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUselessReturnTagRector' => $baseDir . '/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php',
'Rector\\DeadCode\\Rector\\Class_\\TargetRemoveClassMethodRector' => $baseDir . '/rules/DeadCode/Rector/Class_/TargetRemoveClassMethodRector.php',
'Rector\\DeadCode\\Rector\\Concat\\RemoveConcatAutocastRector' => $baseDir . '/rules/DeadCode/Rector/Concat/RemoveConcatAutocastRector.php',
'Rector\\DeadCode\\Rector\\ConstFetch\\RemovePhpVersionIdCheckRector' => $baseDir . '/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php',
'Rector\\DeadCode\\Rector\\Expression\\RemoveDeadStmtRector' => $baseDir . '/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php',
Expand Down Expand Up @@ -1603,6 +1604,7 @@
'Rector\\DeadCode\\UselessIfCondBeforeForeachDetector' => $baseDir . '/rules/DeadCode/UselessIfCondBeforeForeachDetector.php',
'Rector\\DeadCode\\ValueObject\\BinaryToVersionCompareCondition' => $baseDir . '/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php',
'Rector\\DeadCode\\ValueObject\\PropertyFetchToVariableAssign' => $baseDir . '/rules/DeadCode/ValueObject/PropertyFetchToVariableAssign.php',
'Rector\\DeadCode\\ValueObject\\TargetRemoveClassMethod' => $baseDir . '/rules/DeadCode/ValueObject/TargetRemoveClassMethod.php',
'Rector\\DeadCode\\ValueObject\\VariableAndPropertyFetchAssign' => $baseDir . '/rules/DeadCode/ValueObject/VariableAndPropertyFetchAssign.php',
'Rector\\DeadCode\\ValueObject\\VersionCompareCondition' => $baseDir . '/rules/DeadCode/ValueObject/VersionCompareCondition.php',
'Rector\\Defluent\\NodeAnalyzer\\FluentChainMethodCallNodeAnalyzer' => $baseDir . '/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php',
Expand Down
10 changes: 5 additions & 5 deletions vendor/composer/autoload_real.php
Expand Up @@ -2,7 +2,7 @@

// autoload_real.php @generated by Composer

class ComposerAutoloaderInit099468b8f0503dfa63adfbd0082c61cf
class ComposerAutoloaderInitf4223b92917874ab1dbad62f3f4ea2d4
{
private static $loader;

Expand All @@ -22,17 +22,17 @@ public static function getLoader()
return self::$loader;
}

spl_autoload_register(array('ComposerAutoloaderInit099468b8f0503dfa63adfbd0082c61cf', 'loadClassLoader'), true, true);
spl_autoload_register(array('ComposerAutoloaderInitf4223b92917874ab1dbad62f3f4ea2d4', 'loadClassLoader'), true, true);
self::$loader = $loader = new \Composer\Autoload\ClassLoader(\dirname(__DIR__));
spl_autoload_unregister(array('ComposerAutoloaderInit099468b8f0503dfa63adfbd0082c61cf', 'loadClassLoader'));
spl_autoload_unregister(array('ComposerAutoloaderInitf4223b92917874ab1dbad62f3f4ea2d4', 'loadClassLoader'));

require __DIR__ . '/autoload_static.php';
call_user_func(\Composer\Autoload\ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf::getInitializer($loader));
call_user_func(\Composer\Autoload\ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4::getInitializer($loader));

$loader->setClassMapAuthoritative(true);
$loader->register(true);

$filesToLoad = \Composer\Autoload\ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf::$files;
$filesToLoad = \Composer\Autoload\ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4::$files;
$requireFile = static function ($fileIdentifier, $file) {
if (empty($GLOBALS['__composer_autoload_files'][$fileIdentifier])) {
$GLOBALS['__composer_autoload_files'][$fileIdentifier] = true;
Expand Down
10 changes: 6 additions & 4 deletions vendor/composer/autoload_static.php
Expand Up @@ -4,7 +4,7 @@

namespace Composer\Autoload;

class ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf
class ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4
{
public static $files = array (
'ad155f8f1cf0d418fe49e248db8c661b' => __DIR__ . '/..' . '/react/promise/src/functions_include.php',
Expand Down Expand Up @@ -1811,6 +1811,7 @@ class ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUnusedPromotedPropertyRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/ClassMethod/RemoveUnusedPromotedPropertyRector.php',
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUselessParamTagRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/ClassMethod/RemoveUselessParamTagRector.php',
'Rector\\DeadCode\\Rector\\ClassMethod\\RemoveUselessReturnTagRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/ClassMethod/RemoveUselessReturnTagRector.php',
'Rector\\DeadCode\\Rector\\Class_\\TargetRemoveClassMethodRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/Class_/TargetRemoveClassMethodRector.php',
'Rector\\DeadCode\\Rector\\Concat\\RemoveConcatAutocastRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/Concat/RemoveConcatAutocastRector.php',
'Rector\\DeadCode\\Rector\\ConstFetch\\RemovePhpVersionIdCheckRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/ConstFetch/RemovePhpVersionIdCheckRector.php',
'Rector\\DeadCode\\Rector\\Expression\\RemoveDeadStmtRector' => __DIR__ . '/../..' . '/rules/DeadCode/Rector/Expression/RemoveDeadStmtRector.php',
Expand Down Expand Up @@ -1848,6 +1849,7 @@ class ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf
'Rector\\DeadCode\\UselessIfCondBeforeForeachDetector' => __DIR__ . '/../..' . '/rules/DeadCode/UselessIfCondBeforeForeachDetector.php',
'Rector\\DeadCode\\ValueObject\\BinaryToVersionCompareCondition' => __DIR__ . '/../..' . '/rules/DeadCode/ValueObject/BinaryToVersionCompareCondition.php',
'Rector\\DeadCode\\ValueObject\\PropertyFetchToVariableAssign' => __DIR__ . '/../..' . '/rules/DeadCode/ValueObject/PropertyFetchToVariableAssign.php',
'Rector\\DeadCode\\ValueObject\\TargetRemoveClassMethod' => __DIR__ . '/../..' . '/rules/DeadCode/ValueObject/TargetRemoveClassMethod.php',
'Rector\\DeadCode\\ValueObject\\VariableAndPropertyFetchAssign' => __DIR__ . '/../..' . '/rules/DeadCode/ValueObject/VariableAndPropertyFetchAssign.php',
'Rector\\DeadCode\\ValueObject\\VersionCompareCondition' => __DIR__ . '/../..' . '/rules/DeadCode/ValueObject/VersionCompareCondition.php',
'Rector\\Defluent\\NodeAnalyzer\\FluentChainMethodCallNodeAnalyzer' => __DIR__ . '/../..' . '/packages/Defluent/NodeAnalyzer/FluentChainMethodCallNodeAnalyzer.php',
Expand Down Expand Up @@ -3061,9 +3063,9 @@ class ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf
public static function getInitializer(ClassLoader $loader)
{
return \Closure::bind(function () use ($loader) {
$loader->prefixLengthsPsr4 = ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInit099468b8f0503dfa63adfbd0082c61cf::$classMap;
$loader->prefixLengthsPsr4 = ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4::$prefixLengthsPsr4;
$loader->prefixDirsPsr4 = ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4::$prefixDirsPsr4;
$loader->classMap = ComposerStaticInitf4223b92917874ab1dbad62f3f4ea2d4::$classMap;

}, null, ClassLoader::class);
}
Expand Down

0 comments on commit 96d8a22

Please sign in to comment.