-
-
Notifications
You must be signed in to change notification settings - Fork 673
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Updated Rector to commit 6c86d9ac707d711ea6ffb521ff2c6223578b68f9
rectorphp/rector-src@6c86d9a [DX] Add symfony configs set
- Loading branch information
1 parent
32fd066
commit fb1ff0f
Showing
7 changed files
with
109 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 changes: 99 additions & 0 deletions
99
...tor-symfony/rules/Symfony62/Rector/Class_/SecurityAttributeToIsGrantedAttributeRector.php
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,99 @@ | ||
| <?php | ||
|
|
||
| declare (strict_types=1); | ||
| namespace Rector\Symfony\Symfony62\Rector\Class_; | ||
|
|
||
| use PhpParser\Node; | ||
| use PhpParser\Node\Arg; | ||
| use PhpParser\Node\Expr; | ||
| use PhpParser\Node\Expr\New_; | ||
| use PhpParser\Node\Name\FullyQualified; | ||
| use PhpParser\Node\Stmt\Class_; | ||
| use PhpParser\Node\Stmt\ClassMethod; | ||
| use Rector\Rector\AbstractRector; | ||
| use Rector\ValueObject\PhpVersionFeature; | ||
| use Rector\VersionBonding\Contract\MinPhpVersionInterface; | ||
| use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; | ||
| use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | ||
| /** | ||
| * @changelog https://github.com/symfony/symfony/pull/45415#issuecomment-1077625813 | ||
| * @changelog https://github.com/symfony/symfony/pull/46907 | ||
| * | ||
| * @see \Rector\Symfony\Tests\Symfony62\Rector\Class_\SecurityAttributeToIsGrantedAttributeRector\SecurityAttributeToIsGrantedAttributeRectorTest | ||
| */ | ||
| final class SecurityAttributeToIsGrantedAttributeRector extends AbstractRector implements MinPhpVersionInterface | ||
| { | ||
| /** | ||
| * @var string | ||
| */ | ||
| private const SECURITY_ATTRIBUTE = 'Sensio\\Bundle\\FrameworkExtraBundle\\Configuration\\Security'; | ||
| /** | ||
| * @var string | ||
| */ | ||
| private const IS_GRANTED_ATTRIBUTE = 'Symfony\\Component\\Security\\Http\\Attribute\\IsGranted'; | ||
| public function provideMinPhpVersion() : int | ||
| { | ||
| return PhpVersionFeature::ATTRIBUTES; | ||
| } | ||
| public function getRuleDefinition() : RuleDefinition | ||
| { | ||
| return new RuleDefinition('Replaces #[Security] framework-bundle attribute with Symfony native #[IsGranted] one', [new CodeSample(<<<'CODE_SAMPLE' | ||
| use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security; | ||
| class PostController extends Controller | ||
| { | ||
| #[Security("is_granted('ROLE_ADMIN') and is_granted('ROLE_FRIENDLY_USER')")] | ||
| public function index() | ||
| { | ||
| } | ||
| } | ||
| CODE_SAMPLE | ||
| , <<<'CODE_SAMPLE' | ||
| use Symfony\Component\ExpressionLanguage\Expression; | ||
| use Symfony\Component\Security\Http\Attribute\IsGranted; | ||
| class PostController extends Controller | ||
| { | ||
| #[IsGranted(new Expression("is_granted('ROLE_ADMIN') and is_granted('ROLE_FRIENDLY_USER')"))] | ||
| public function index() | ||
| { | ||
| } | ||
| } | ||
| CODE_SAMPLE | ||
| )]); | ||
| } | ||
| /** | ||
| * @return array<class-string<Node>> | ||
| */ | ||
| public function getNodeTypes() : array | ||
| { | ||
| return [Class_::class, ClassMethod::class]; | ||
| } | ||
| /** | ||
| * @param Class_|ClassMethod $node | ||
| */ | ||
| public function refactor(Node $node) : ?Node | ||
| { | ||
| $hasChanged = \false; | ||
| foreach ($node->attrGroups as $attrGroup) { | ||
| foreach ($attrGroup->attrs as $attribute) { | ||
| if (!$this->isName($attribute->name, self::SECURITY_ATTRIBUTE)) { | ||
| continue; | ||
| } | ||
| $attribute->name = new FullyQualified(self::IS_GRANTED_ATTRIBUTE); | ||
| $firstArg = $attribute->args[0]; | ||
| $attribute->args[0]->value = $this->wrapToNewExpression($firstArg->value); | ||
| $hasChanged = \true; | ||
| } | ||
| } | ||
| if ($hasChanged) { | ||
| return $node; | ||
| } | ||
| return null; | ||
| } | ||
| private function wrapToNewExpression(Expr $expr) : New_ | ||
| { | ||
| $args = [new Arg($expr)]; | ||
| return new New_(new FullyQualified('Symfony\\Component\\ExpressionLanguage\\Expression'), $args); | ||
| } | ||
| } |