Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[applying] Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector throw NotImplementedException #2805

Closed
yuzuofu opened this issue Feb 6, 2020 · 0 comments · Fixed by #2813
Labels

Comments

@yuzuofu
Copy link

yuzuofu commented Feb 6, 2020

Subject Details
Rector version v0.6.14
PHP version PHP 7.4
Full Command vendor/bin/rector process ./demo.php --set php71 --only "Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector" --debug
Demo link https://github.com/yuzuofu/rector-test/blob/master/demo.php
rector.yaml no rector.yaml

Current Behaviour

[parsing] demo.php
[refactoring] demo.php
[applying] Rector\Php71\Rector\BinaryOp\BinaryOpBetweenNumberAndStringRector

Fatal error: Uncaught Rector\Exception\NotImplementedException in /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/PerNodeTypeResolver/ScalarTypeResolver.php:45
Stack trace:
#0 /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/NodeTypeResolver.php(366): Rector\NodeTypeResolver\PerNodeTypeResolver\ScalarTypeResolver->resolve(Object(PhpParser\Node\Scalar\Encapsed))
#1 /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/NodeTypeResolver.php(178): Rector\NodeTypeResolver\NodeTypeResolver->resolveFirstType(Object(PhpParser\Node\Scalar\Encapsed))
#2 /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/TypeAnalyzer/ArrayTypeAnalyzer.php(64): Rector\NodeTypeResolver\NodeTypeResolver->resolve(Object(PhpParser\Node\Scalar\Encapsed))
#3 /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/NodeTypeResolver.php(486): Rector\NodeTypeResolver\TypeAnalyzer\ArrayTypeAnalyzer->isArrayType(Object(PhpParser\Node\Scalar\Encapsed))
#4 /var/www/info/vendor/rector/rector/package in /var/www/info/vendor/rector/rector/packages/NodeTypeResolver/src/PerNodeTypeResolver/ScalarTypeResolver.php on line 45

Minimal PHP Code Causing Issue

<?php 

// put file content here
$a = "test";
$b = "that is test";
assert($b=="this is $a");

Expected Behaviour

no behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants