[Laravel] Add RequestStaticValidateToInjectRector

[TomasVotruba]

Ref #1138 ,
ref #290

  use Illuminate\Http\Request;
	  
  class SomeClass
  {
-     public function store()
+     public function store(\Illuminate\Http\Request $request)
      {
-         $validatedData = Request::validate(['some_attribute' => 'required']);
+         $validatedData = $request->validate(['some_attribute' => 'required']);
      }
  }

[TomasVotruba]

@mrpixeldream Could I ask you for a review? I hope I got that right 😅

[barryvdh]

Why just the validate? Could also be for the other Requests calls, right?

[TomasVotruba]

Sure. Again, I don't use Laravel so I have no idea about the logic here :).

If you provide list of these magic static methods, that can be changed here, we can update it

[barryvdh]

Ah my bad, I guess usually it's the Request facade, not the Request class itself that is called static.
I usually prefer to inject the Request class like this ($request in the controller method), but that's already done by the other call (all facades to injection in __construct). But I would say that the Request object belongs to the current controller action usually, so it would belong there. But could be a matter of preference.

[TomasVotruba]

I'm not sure I understand. It's in controller action.

See description of this PR:

[barryvdh]

This one is, but not the Facade one (that is done in #1140)

[TomasVotruba]

Why do you talk about different PR here? I'm confused

[TomasVotruba]

Mergin for validate method as it is now

[nschoellhorn]

Yeah, seems fine 👍
If you want, you can check out https://github.com/laravel/framework/blob/5.8/src/Illuminate/Support/Facades/Request.php for a list of methods that are usable on the facade and hence also on the request object. The docblock shows all of them. Request::get() is frequently used as well for example. I am of course open to reviewing if you want that, just wait a little longer :P

[barryvdh]

Because people usually call the Request facade, not the actual class. eg. Request::get() is usually an alias for Illuminate\Support\Facades\Request, not for \Illuminate\Http\Request. So those calls are already handled by the other PR (which handles all facades)

[TomasVotruba]

The code-review would be best 👍

[nschoellhorn]

The rest looks good, even though it seems you put something in this PR that doesn't belong there regarding the name. But that's your choice anyways! :)