[PHP 74] Add ChangeReflectionTypeToStringToGetNameRector #2182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
php74-ref-type
branch
2 times, most recently
from
7fb5f47
to
6f36f58
Compare
TomasVotruba
commented
Oct 19, 2019
packages/NodeTypeResolver/src/DependencyInjection/PHPStanServicesFactory.php
Outdated
Show resolved
Hide resolved
TomasVotruba
force-pushed
the
php74-ref-type
branch
2 times, most recently
from
b85537c
to
190f4c6
Compare
TomasVotruba
force-pushed
the
php74-ref-type
branch
from
5f75472
to
4dfd0a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes deprecated
TypeReflection::__toString()method:public function go(ReflectionFunction $reflectionFunction) { $parameterReflection = $reflectionFunction->getParameters()[0]; - $paramType = (string) $parameterReflection->getType(); + $paramType = (string) ($parameterReflection->getType() ? $parameterReflection->getType()->getName() : null); - $stringValue = 'hey' . $reflectionFunction->getReturnType(); + $stringValue = 'hey' . ($reflectionFunction->getReturnType() ? $reflectionFunction->getReturnType()->getName() : null); }Closes #2160
Should cover cases like: