[SOLID] Change if && to early return (more than two conditions) #4390
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dobryy
force-pushed
the
solid-and-if-early-return-more-than-two-conditions
branch
from
d5de71f
to
27c9235
Compare
dobryy
changed the title
dobryy
force-pushed
the
solid-and-if-early-return-more-than-two-conditions
branch
from
4b09c3d
to
aaaabc9
Compare
|
@TomasVotruba if the pipeline will be green it is ready for review. |
dobryy
changed the title
dobryy
force-pushed
the
solid-and-if-early-return-more-than-two-conditions
branch
from
0ee88dc
to
195b350
Compare
|
@TomasVotruba PHPStan issues were related to some new Simplify rule. I rebased on master once more time, now it should be fine. |
TomasVotruba
approved these changes
Oct 11, 2020
TomasVotruba
deleted the
solid-and-if-early-return-more-than-two-conditions
branch
|
Thank you |
TomasVotruba
added a commit
that referenced
this pull request
Jul 1, 2023
rectorphp/rector-src@2161084 [DeadCode] Skip non typed param numeric check on RecastingRemovalRector (#4390)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up: #4344 (comment)
Related to: #4071