[Symfony 5.2] Add FormBuilderSetDataMapperRector #5339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
changed the title
samsonasik
changed the title
|
@TomasVotruba it seems there is new phpstan release that make the following error in tests: 1) Rector\CodeQuality\Tests\Rector\Class_\CompleteDynamicPropertiesRector\CompleteDynamicPropertiesRectorTest::test with data set #7 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
Error: Class 'ReflectionUnionType' not found
phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionUnionType.php:9
phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionType.php:27
phar:///home/runner/work/rector/rector/vendor/phpstan/phpstan/phpstan.phar/vendor/ondrejmirtes/better-reflection/src/Reflection/Adapter/ReflectionParameter.php:176and phpstan error: WARNING] Internal error: Internal error: Internal error. in file
/home/runner/work/rector/rector/rules/php80/src/MatchAndRefactor/StrS
tartsWithMatchAndRefactor/AbstractMatchAndRefactor.php
Run PHPStan with --debug option and post the stack trace to:
https://github.com/phpstan/phpstan/issues/new?template=Bug_report.md
|
|
The error is only happen in php 7.4 https://github.com/rectorphp/rector/pull/5339/checks?check_run_id=1782400087#step:6:93 |
|
@TomasVotruba using exact phpstan version 0.12.69 seems fixed the error in php 7.4 6003afb . All checks have passed 🎉 @TomasVotruba it is ready for review. |
samsonasik
force-pushed
the
symfony52-property-path-accessor
branch
from
916dad2
to
6003afb
Compare
simivar
approved these changes
Jan 28, 2021
|
I got same problem with phpstan here in Symplify: https://github.com/symplify/symplify/pull/2876/files/32c7349c840919157c3ad848e6cdb36a1c2de441#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34 It's related to |
|
Thanks 👍 |
TomasVotruba
added a commit
that referenced
this pull request
Dec 8, 2023
rectorphp/rector-src@0a2dc3d Fix array type if property is used in TypedPropertyFromStrictConstructorRector (#5339)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #4824