Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Renaming] Skip RenameMethodRector when class implements interface method #5557

Merged
merged 5 commits into from
Feb 15, 2021

Conversation

samsonasik
Copy link
Member

No description provided.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

Copy link
Contributor

@ruudk ruudk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@samsonasik samsonasik changed the title [RenameMethodRector] Skip RenameMethodRector when class implements interface method [Renaming] Skip RenameMethodRector when class implements interface method Feb 15, 2021
@TomasVotruba
Copy link
Member

Thanks 👍

@TomasVotruba TomasVotruba merged commit cbebb9a into master Feb 15, 2021
@TomasVotruba TomasVotruba deleted the close-5554 branch February 15, 2021 16:21
@ruudk
Copy link
Contributor

ruudk commented Feb 15, 2021

I tested this PR on my project now that it's in master and notice that it doesn't work.

Turns out it doesn't work when using wildcards like this:

            RenameMethodRector::METHOD_CALL_RENAMES => ValueObjectInliner::inline([
                new MethodCallRename('TicketSwap\**\Handler\*', 'handle', '__invoke'),
                new MethodCallRename('TicketSwap\**\Subscriber\*', 'notify', '__invoke'),
                new MethodCallRename('TicketSwap\**\Query\*', 'handle', '__invoke'),
            ]),

Any idea what this could be?

@samsonasik
Copy link
Member Author

@ruudk could you add test case? Thank you.

@ruudk
Copy link
Contributor

ruudk commented Feb 15, 2021

@samsonasik Done #5564

TomasVotruba added a commit that referenced this pull request Feb 4, 2024
rectorphp/rector-src@ba1cad3 [Privatization] Fix reprint with attribute on FinalizeTestCaseClassRector (#5557)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants