-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Renaming] Skip RenameMethodRector when class implements interface method #5557
Conversation
This works, but it still tries to change the method call :(
All checks have passed 🎉 @TomasVotruba it is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Thanks 👍 |
I tested this PR on my project now that it's in master and notice that it doesn't work. Turns out it doesn't work when using wildcards like this: RenameMethodRector::METHOD_CALL_RENAMES => ValueObjectInliner::inline([
new MethodCallRename('TicketSwap\**\Handler\*', 'handle', '__invoke'),
new MethodCallRename('TicketSwap\**\Subscriber\*', 'notify', '__invoke'),
new MethodCallRename('TicketSwap\**\Query\*', 'handle', '__invoke'),
]), Any idea what this could be? |
@ruudk could you add test case? Thank you. |
@samsonasik Done #5564 |
rectorphp/rector-src@ba1cad3 [Privatization] Fix reprint with attribute on FinalizeTestCaseClassRector (#5557)
No description provided.