Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TASK] Add fallback mechanism to load default extensions #6359

Closed
wants to merge 1 commit into from
Closed

[TASK] Add fallback mechanism to load default extensions #6359

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config/config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
$containerConfigurator->import(__DIR__ . '/services-packages.php');
$containerConfigurator->import(__DIR__ . '/parameters.php');

$extensionConfigResolver = new ExtensionConfigResolver();
$extensionConfigResolver = new ExtensionConfigResolver(__DIR__);
$extensionConfigFiles = $extensionConfigResolver->provide();
foreach ($extensionConfigFiles as $extensionConfigFile) {
$containerConfigurator->import($extensionConfigFile->getRealPath());
Expand Down
46 changes: 42 additions & 4 deletions src/Bootstrap/ExtensionConfigResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,49 @@
final class ExtensionConfigResolver
{
/**
* @return SmartFileInfo[]
* @var array<int, string>
*/
private const DEFAULT_EXTENSIONS = [
'rector-symfony',
'rector-nette',
'rector-laravel',
'rector-phpunit',
'rector-cakephp',
'rector-doctrine',
];

/**
* @var array<string, SmartFileInfo>
*/
private $defaultConfigFileInfos;

public function __construct(string $configDirectoryPath)
{
$defaultConfigFileInfos = [];
foreach (self::DEFAULT_EXTENSIONS as $defaultExtension) {
$rectorRoot = $configDirectoryPath . sprintf('/../vendor/rector/%s/config/config.php', $defaultExtension);
$rectorSubPackage = $configDirectoryPath . sprintf('/../../%s/config/config.php', $defaultExtension);

foreach ([$rectorRoot, $rectorSubPackage] as $possibleFilePath) {
if (! file_exists($possibleFilePath)) {
continue;
}

$packageName = sprintf('rector/%s', $defaultExtension);

$defaultConfigFileInfos[$packageName] = new SmartFileInfo($possibleFilePath);
}
}

$this->defaultConfigFileInfos = $defaultConfigFileInfos;
}

/**
* @return array<string, SmartFileInfo>
*/
public function provide(): array
{
$configFileInfos = [];
$configFileInfos = $this->defaultConfigFileInfos;

if (! class_exists('Rector\RectorInstaller\GeneratedConfig')) {
return $configFileInfos;
Expand All @@ -27,7 +65,7 @@ public function provide(): array
}

$generatedConfigDirectory = dirname($generatedConfigReflectionClass->getFileName());
foreach (GeneratedConfig::EXTENSIONS as $extensionConfig) {
foreach (GeneratedConfig::EXTENSIONS as $extensionKey => $extensionConfig) {
foreach ($extensionConfig['extra']['includes'] ?? [] as $includedFile) {
$includedFilePath = $this->resolveIncludeFilePath(
$extensionConfig,
Expand All @@ -39,7 +77,7 @@ public function provide(): array
$includedFilePath = sprintf('%s/%s', $extensionConfig['install_path'], $includedFile);
}

$configFileInfos[] = new SmartFileInfo($includedFilePath);
$configFileInfos[$extensionKey] = new SmartFileInfo($includedFilePath);
}
}

Expand Down