Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK] Add fallback mechanism to load default extensions #6359

Closed
wants to merge 1 commit into from

Conversation

sabbelasichon
Copy link
Contributor

  • If the rector-installer failed or is not executed due to --no-scripts flag at least the old default extensions are loaded

Resolves: #6347

- If the rector-installer failed or is not executed due to --no-scripts flag at least the old default extensions are loaded

Resolves: rectorphp#6347
@TomasVotruba
Copy link
Member

TomasVotruba commented May 5, 2021

I'm not sure having 2 ways to install packages is a good approach. This is what we had before and tried to get rid of :)
Devs need to learn the package is installing extension, like we did with PHPStan installer and flex installer.

IMO that reported bug is a wrong abstraction in our part. Mismatch of tags with non-existing class or something.

@sabbelasichon
Copy link
Contributor Author

sabbelasichon commented May 5, 2021

@TomasVotruba It is meant as a fallback solution to circumvent this error. It is always the rector-nette package. Maybe it is sufficient to only add this package here. I have never looked closely to the bug. But maybe we can get rid of after some time.

@TomasVotruba
Copy link
Member

That's the composer install convention on any plugin. I've decoupled NetteToSymfony to own package to remove core dependency on extension: #6360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.10.19] NetteToSymfony error
2 participants