Pricing tests #24
Merged
Pricing tests #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrudner
force-pushed
the
pricing-tests
branch
from
f076f3e
to
6b372ed
Compare
dbrudner
commented
Jan 29, 2020
dbrudner
force-pushed
the
pricing-tests
branch
from
6b372ed
to
c3089c9
Compare
dbrudner
commented
Jan 29, 2020
dbrudner
commented
Jan 29, 2020
dbrudner
force-pushed
the
release/pricing
branch
from
545f49d
to
24869db
Compare
dbrudner
force-pushed
the
pricing-tests
branch
2 times, most recently
from
8ab5115
to
635d184
Compare
Pull Request Test Coverage Report for Build e94e558897e70d953ee086f40a93ab8318ac0190-PR-24
💛 - Coveralls |
dbrudner
force-pushed
the
pricing-tests
branch
4 times, most recently
from
e23cbda
to
c6a66b3
Compare
chrissrogers
reviewed
Feb 4, 2020
dbrudner
force-pushed
the
release/pricing
branch
from
035d6fb
to
2771a76
Compare
dbrudner
force-pushed
the
pricing-tests
branch
9 times, most recently
from
724f7bc
to
bf8cc6b
Compare
chrissrogers
reviewed
Feb 7, 2020
test/use-checkout-pricing.test.js
Outdated
| cb(); | ||
| return checkoutPricingReturn; | ||
| }), | ||
| giftcard: jest.fn(() => checkoutPricingReturn), |
There was a problem hiding this comment.
I think this needs to be giftCard
There was a problem hiding this comment.
The method right now is giftcard coming back from PRICING_METHODS, I know there's a PR to deprecate this in favor of giftCard, should we switch to use this method instead? recurly/recurly-js#580
dbrudner
force-pushed
the
pricing-tests
branch
from
bf8cc6b
to
e459e32
Compare
dbrudner
force-pushed
the
pricing-tests
branch
from
e459e32
to
d55f53f
Compare
chrissrogers
approved these changes
Feb 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests only cover the
subscriptionsinterface insideuseCheckoutPricingand base functionality.After this is merged, I'll open up additional PRs to cover the rest of the interface.
Totally open to feedback and willing to change anything.