Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes fraud form detection fallback #580

Merged
merged 2 commits into from
Feb 7, 2020
Merged

Fixes fraud form detection fallback #580

merged 2 commits into from
Feb 7, 2020

Conversation

chrissrogers
Copy link
Member

  • better errors and handling for fraud form detection
  • refractors Recurly.giftCard
  • improves tests and coverage

@chrissrogers
Improves recurly.giftCard
891d34e 
- Adds missing gift card parameter error
- Migrates `options.giftcard` parameter to `options.code`
- Improves `recurly.giftCard` tests
dbrudner
dbrudner reviewed Feb 6, 2020
View reviewed changes
test/support/fixtures.js Outdated Show resolved Hide resolved
@chrissrogers
Improves recurly.Fraud tests
e2b4e17 
- Adds multi-scenario fraud tests
- Adds GET /fraud/info fixture
- Adds make test-debug
@dbrudner dbrudner mentioned this pull request Feb 7, 2020
Merged
@chrissrogers chrissrogers merged commit 521b8e6 into master Feb 7, 2020
@chrissrogers chrissrogers deleted the tests branch February 7, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbrudner dbrudner dbrudner approved these changes

@calebbarde calebbarde Awaiting requested review from calebbarde

Assignees
No one assigned
Labels
enhancement tests & build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrissrogers @dbrudner