Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ref usage #54

Merged
merged 1 commit into from
Apr 8, 2020
Merged

Fix ref usage #54

merged 1 commit into from
Apr 8, 2020

Conversation

HaNdTriX
Copy link
Contributor

@HaNdTriX HaNdTriX commented Apr 7, 2020

  • React.createRef() will always create a new ref (for class components).
  • React.useRef() will reuse the old ref (for function components).

Have a nice day.

@dbrudner
Copy link
Contributor

dbrudner commented Apr 7, 2020

Awesome contribution!! This looks great from a cursory glance, we'll take a closer look and give a thorough review as soon as we can.

@dbrudner
Copy link
Contributor

dbrudner commented Apr 8, 2020

@HaNdTriX This is fantastic, great contribution 🔥 👍

@dbrudner dbrudner merged commit 6bdde57 into recurly:master Apr 8, 2020
@coveralls
Copy link

coveralls commented Jul 4, 2024

Pull Request Test Coverage Report for Build 0ee7961ff6d3230516719ffc6b1b77ebe89fe601-PR-54

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.887%

Totals Coverage Status
Change from base Build 63eaf9a71f63f3948f16cb86f309fe642987ebd4: 0.0%
Covered Lines: 198
Relevant Lines: 202

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants