-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Add RevRec General Ledger Accounts Feature #813
[V2] Add RevRec General Ledger Accounts Feature #813
Conversation
@@ -128,55 +128,27 @@ public HttpStatusCode PerformRequest(HttpRequestMethod method, string urlPath) | |||
} | |||
|
|||
protected virtual HttpStatusCode PerformRequest(HttpRequestMethod method, string urlPath, | |||
WriteXmlDelegate writeXmlDelegate, ReadXmlDelegate readXmlDelegate, ReadXmlListDelegate readXmlListDelegate, ReadResponseDelegate reseponseDelegate) | |||
WriteXmlDelegate writeXmlDelegate, ReadXmlDelegate readXmlDelegate, ReadXmlListDelegate readXmlListDelegate, ReadResponseDelegate responseDelegate) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo legit has existed for 5 years. 😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a bit of refactoring in this file to break a giant method down into a handful of smaller ones in hopes of improving readability.
146bf6f
to
57f945b
Compare
57f945b
to
e94ca5d
Compare
e94ca5d
to
70af730
Compare
devQA + 1 (tests passing) |
[Full Changelog](1.17.34...2.0.0) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
[Full Changelog](1.17.34...1.17.35) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
[Full Changelog](1.17.34...1.17.36) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
This change creates the
GeneralLedgerAccount
entity for the V2 client, the primary entity concerning the new (and upcoming) RevRec API features.Examples