Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[V2] Add RevRec General Ledger Accounts Feature #813

Merged

Conversation

Smolations
Copy link

@Smolations Smolations commented Jan 23, 2024

This change creates the GeneralLedgerAccount entity for the V2 client, the primary entity concerning the new (and upcoming) RevRec API features.

Examples

// creating: (account type can be Liability or Revenue)
var gla = new GeneralLedgerAccount("my accounting code", GeneralLedgerAccountType.Revenue);
gla.Create();

// getting:
var glaJustCreated = GeneralLedgerAccounts.Get(gla.Id);

// updating: (can also update the Code, but _not_ the AccountType)
gla.Description = "This is a new description";
gla.Update();

// listing:
var glas = GeneralLedgerAccounts.List();

// in addition to FilterCriteria, can also filter by account type:
var glas = GeneralLedgerAccounts.List(GeneralLedgerAccountType.Liability);

@Smolations Smolations changed the title [add-revrec-general-ledger-accounts-feature] Add RevRec General Ledger Accounts Feature Jan 23, 2024
@Smolations Smolations added the V2 V2 Client label Jan 23, 2024
@Smolations Smolations changed the title Add RevRec General Ledger Accounts Feature [V2] Add RevRec General Ledger Accounts Feature Jan 23, 2024
@@ -128,55 +128,27 @@ public HttpStatusCode PerformRequest(HttpRequestMethod method, string urlPath)
}

protected virtual HttpStatusCode PerformRequest(HttpRequestMethod method, string urlPath,
WriteXmlDelegate writeXmlDelegate, ReadXmlDelegate readXmlDelegate, ReadXmlListDelegate readXmlListDelegate, ReadResponseDelegate reseponseDelegate)
WriteXmlDelegate writeXmlDelegate, ReadXmlDelegate readXmlDelegate, ReadXmlListDelegate readXmlListDelegate, ReadResponseDelegate responseDelegate)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This typo legit has existed for 5 years. 😅

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a bit of refactoring in this file to break a giant method down into a handful of smaller ones in hopes of improving readability.

@Smolations Smolations force-pushed the add-revrec-general-ledger-accounts-feature branch from 146bf6f to 57f945b Compare January 23, 2024 20:34
@Smolations Smolations marked this pull request as ready for review January 23, 2024 20:40
@Smolations Smolations force-pushed the add-revrec-general-ledger-accounts-feature branch from 57f945b to e94ca5d Compare January 25, 2024 19:27
@Smolations Smolations force-pushed the add-revrec-general-ledger-accounts-feature branch from e94ca5d to 70af730 Compare January 25, 2024 19:28
@8eth
Copy link

8eth commented Jan 26, 2024

devQA + 1 (tests passing)

@8eth 8eth merged commit 99a44aa into add-revrec-features Jan 26, 2024
3 checks passed
@8eth 8eth deleted the add-revrec-general-ledger-accounts-feature branch January 26, 2024 17:16
@Smolations Smolations mentioned this pull request Jan 26, 2024
recurly-integrations pushed a commit that referenced this pull request Mar 13, 2024
[Full Changelog](1.17.34...2.0.0)

**Merged Pull Requests**

- [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations))
- Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
recurly-integrations pushed a commit that referenced this pull request Mar 13, 2024
[Full Changelog](1.17.34...1.17.35)

**Merged Pull Requests**

- [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations))
- Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
recurly-integrations pushed a commit that referenced this pull request Mar 13, 2024
[Full Changelog](1.17.34...1.17.36)

**Merged Pull Requests**

- [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations))
- [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations))
- Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations))
- [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V2 V2 Client
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants