-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[V2] Add RevRec settings to the Plan entity #818
Conversation
415ea82
to
18f193f
Compare
default revrec settings - adds setup fee revrec settings manually
533e871
to
a5091aa
Compare
@@ -5,7 +5,7 @@ | |||
|
|||
namespace Recurly | |||
{ | |||
public class Plan : RecurlyEntity | |||
public class Plan : RevRecEntity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this changing? Is there still a RecurlyEntity
being used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if you look at the thing taking its place, RevRecEntity
, you will see that it is inheriting from RecurlyEntity
, so the new class is just fitted "in between" the original two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh okay. Cool. That makes sense.
DevQA+1 |
[Full Changelog](1.17.34...2.0.0) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
[Full Changelog](1.17.34...1.17.35) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
[Full Changelog](1.17.34...1.17.36) **Merged Pull Requests** - [V2] Add RevRec Settings to Adjustments [#822](#822) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to AddOns [#821](#821) ([Smolations](https://github.com/Smolations)) - [V2] Adds RevRec features to Item, GiftCard, and ShippingMethod [#819](#819) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to the Plan entity [#818](#818) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec settings to business entities [#817](#817) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec Performance Obligations Feature [#816](#816) ([Smolations](https://github.com/Smolations)) - Add revrec features [#815](#815) ([Smolations](https://github.com/Smolations)) - [V2] Add RevRec General Ledger Accounts Feature [#813](#813) ([Smolations](https://github.com/Smolations))
Adds the following properties to the
Plan
entity for the V2 client:LiabilityGlAccountId
RevenueGlAccountId
PerformanceObligationId
SetupFeeLiabilityGlAccountId
SetupFeeRevenueGlAccountId
SetupFeePerformanceObligationId
Examples
The following examples only show the base fee RevRec settings for brevity, but the
SetupFee*
properties behave the same way.