Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to support cuit tax identifiers #684

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Add test to support cuit tax identifiers #684

merged 1 commit into from
Jul 7, 2021

Conversation

cyberxander90
Copy link
Contributor

Tax identifier types could be cpf or cuit.

Copy link
Contributor

@jpgnotgif jpgnotgif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a negative test for a type other than cpf or cuit

@coveralls
Copy link

coveralls commented Jun 23, 2021

Coverage Status

Coverage remained the same at 92.3% when pulling f010cb0 on FK-707 into 0cf6989 on master.

@cyberxander90
Copy link
Contributor Author

Looks good. Please add a negative test for a type other than cpf or cuit

There is a negative test here

@brittany-wood brittany-wood merged commit 8f7f75b into master Jul 7, 2021
@brittany-wood brittany-wood deleted the FK-707 branch July 7, 2021 15:00
recurly-integrations pushed a commit that referenced this pull request Aug 12, 2021
[Full Changelog](v4.16.2...v4.17.0)

**Merged Pull Requests**

- Revert "add security to github CODEOWNER file" [#688](#688) ([eternal44](https://github.com/eternal44))
- Add support to SagePay 3DS2 [#687](#687) ([cyberxander90](https://github.com/cyberxander90))
- add security to github CODEOWNER file [#685](#685) ([eternal44](https://github.com/eternal44))
- Add test to support cuit tax identifiers [#684](#684) ([cyberxander90](https://github.com/cyberxander90))
- Add fields and details types to RecurlyError [#680](#680) ([cyberxander90](https://github.com/cyberxander90))

**Closed Issues**

- Add a line item for trial in apple pay payment sheet [#686](#686)
- Better validation on fly ? [#679](#679)

##### Minified MD5 Checksum
```
ea649ad4b380c105fb2f2bd61f0b389e ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
pr4yLjXl243qTyuNXMpfURm9EUPYlF2oRTjJCrpf1VhiTMJH4RBM83zbwrjXLIZt
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants