Round tax amount instead of ceil #690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
judith
force-pushed
the
round_tax_amount
branch
from
96e8e40
to
d9d2ee5
Compare
judith
force-pushed
the
round_tax_amount
branch
5 times, most recently
from
4a6a397
to
90bfa52
Compare
judith
force-pushed
the
round_tax_amount
branch
from
90bfa52
to
74198a0
Compare
Change the ceil to round in the taxCeil function as tax should be rounded based on regular rounding rules instead of always rounding up to the next value. Update the function name and filename to match the change in functionality.
judith
force-pushed
the
round_tax_amount
branch
from
74198a0
to
8901926
Compare
|
The builds here are marked failing because the coverage jobs were re-run on unique build ids, causing those jobs to fail. All unit and e2e tests have passed in those builds. |
chrissrogers
approved these changes
Oct 27, 2021
recurly-integrations
pushed a commit
that referenced
this pull request
Nov 9, 2021
[Full Changelog](v4.18.0...v4.18.1) **Merged Pull Requests** - Round tax amount instead of ceil [#690](#690) ([judith](https://github.com/judith)) **Closed Issues** - Outdated types on DefinitelyTyped [#694](#694) ##### Minified MD5 Checksum ``` f5c1a4bfbf8a1fa4314493f1eb413dbb ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` lLZfMuhejEXFJ8bD8xn46Ooyw9Z8ZaduUDIYkHko96+mf6mMJXUm6LQ9NOCVTij7 ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the
ceiltoroundin thetaxCeilfunction as tax should be rounded based on regular rounding rules instead of always rounding up to the next value. Update the function name and filename to match the change in functionality.