Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple pay): populate billingContact with form address fields #797

Merged
merged 1 commit into from
Mar 30, 2023

Conversation

cbarton
Copy link
Member

@cbarton cbarton commented Mar 27, 2023

Apple Pay on the Web supports supplying a billingContact and
shippingContact when creating the session. If provided, it would
populate over the customer's default billing contact on the payment
sheet.

If the form option is supplied, use the address fields that are
populated to populate the billingContact and the shipping fields
that are populated to populate the shippingContact.

This also cleans up the interaction between the form and the token.
Currently, if any of the fields on the form are present, we prefer
that address instead of what is presented and modified on the payment
card. This changes that functionality to always prefer the
billingContact from the payment card when tokenizing the card as
that is what the customer sees when authorizing the payment.

@coveralls
Copy link

coveralls commented Mar 28, 2023

Coverage Status

Coverage: 92.78% (+0.05%) from 92.73% when pulling edbd256 on apple-pay-billing-contact into dd36259 on master.

Base automatically changed from apple-pay-passthrough to master March 29, 2023 18:19
…ields

Apple Pay on the Web supports supplying a `billingContact` and
`shippingContact` when creating the session. If provided, it would
populate over the customer's default billing contact on the payment
sheet.

If the `form` option is supplied, use the address fields that are
populated to populate the `billingContact` and the shipping fields
that are populated to populate the `shippingContact`.

This also cleans up the interaction between the `form` and the token.
Currently, if any of the fields on the `form` are present, we prefer
that address instead of what is presented and modified on the payment
card. This changes that functionality to always prefer the
`billingContact` from the payment card when tokenizing the card as
that is what the customer sees when authorizing the payment.
@chrissrogers chrissrogers merged commit 1ce57c1 into master Mar 30, 2023
@chrissrogers chrissrogers deleted the apple-pay-billing-contact branch March 30, 2023 21:30
recurly-integrations pushed a commit that referenced this pull request Apr 19, 2023
[Full Changelog](v4.22.9...v4.23.0)

**Merged Pull Requests**

- chore(paypal): add types for display options [#812](#812) ([cbarton](https://github.com/cbarton))
- fix(apple pay): Do not teardown Braintree on cancel [#811](#811) ([cbarton](https://github.com/cbarton))
- fix(types): add type definition for Recurly#ready [#810](#810) ([cbarton](https://github.com/cbarton))
- feat(google pay): add support for the paymentDataRequest [#809](#809) ([cbarton](https://github.com/cbarton))
- feat(Apple Pay): allow for customization of event updates [#808](#808) ([cbarton](https://github.com/cbarton))
- Update config type with requiredShippingContactFields [#806](#806) ([BARK-RMILLER](https://github.com/BARK-RMILLER))
- feat(apple pay): add support for `recurringPaymentRequest`, move to `options.paymentRequest` [#804](#804) ([cbarton](https://github.com/cbarton))
- fix(apple pay): emit events when restore pricing addresses [#803](#803) ([cbarton](https://github.com/cbarton))
- chore(apple pay): capture async test errors to fail faster [#802](#802) ([cbarton](https://github.com/cbarton))
- feat(apple pay): populate contacts with pricing addresses [#801](#801) ([cbarton](https://github.com/cbarton))
- feat(apple pay): allow for supportedNetworks selection [#800](#800) ([cbarton](https://github.com/cbarton))
- feat(apple pay): update tax when billing/shipping contact changes [#798](#798) ([cbarton](https://github.com/cbarton))
- feat(apple pay): populate billingContact with form address fields [#797](#797) ([cbarton](https://github.com/cbarton))
- feat(Apple Pay): validate and support more ApplePayPaymentRequest features [#794](#794) ([cbarton](https://github.com/cbarton))
- [feat][google-pay] send raw payment data to server [#789](#789) ([cbarton](https://github.com/cbarton))

**Closed Issues**

- property 'ready' does not exist on type 'Recurly'.ts [#795](#795)
- Missing types definitions for `coupon` method [#698](#698)
- If formRef unmounts during call, recurly.token fails silently. [#697](#697)
- The user can enter 4 digits as the month value in the expiration date field. [#678](#678)

##### Minified MD5 Checksum
```
75584733b78f6ca6c6a65267b07fb9ad ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
pX41INy9qepZfHHYL13noWEbReg+bDOqU2jzjgkC3kkDh36KlPFeiJBxUgca8DtP
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants