Feature: better configs #93

bengioe · 2023-06-06T18:32:12Z

The repository is now at a size where it makes no sense to have arbitrary strings used as hyperparameter names.
This PR replaces the "giant-dict-as-config" with a structured & typed config, which makes each module responsible for defining & documenting its own configuration.

Tasks:

fix tests to use new config
finish writing default configuration docstrings

Because this is a "breaking" change this PR updates the minor version to 1, making this release 0.1.0.

pyproject.toml

src/gflownet/utils/metrics.py

tests/test_frag_env.py

maclandrol

First past, see comments.

pyproject.toml

src/gflownet/algo/advantage_actor_critic.py

src/gflownet/data/sampling_iterator.py

src/gflownet/algo/trajectory_balance.py

src/gflownet/tasks/config.py

src/gflownet/tasks/qm9/qm9.py

src/gflownet/train.py

hadim

See a few comments below. Most of them are FYI mostly!

Nice refactoring and I guess it will make config management much easier. I also appreciate the nice and explicit variable naming (something that is underestimated IMO xD).

src/gflownet/algo/advantage_actor_critic.py

src/gflownet/config.py

src/gflownet/tasks/config.py

src/gflownet/tasks/qm9/qm9.py

src/gflownet/tasks/seh_frag.py

bengioe added 18 commits May 30, 2023 10:23

little test

0f5ca52

new config structure - in progress

0c4d8cb

trying config by names

e660d40

further refactor progress

76656a6

better pyi sort + fix moo example

62ac601

tox

bddce69

import fixes

84c649b

add SQL + fix n_valid

a91a1f9

tox test

c302720

fix mypy hook and convert qm9 to new cfg

8dfb772

better config generation

59f2202

use generated config.py

5fe23ed

use generated config.py

4fc86a0

fix rng call types

fa33f3a

fix test + tox

79718ae

better config doc

c2851b3

fix deps

0f271b3

Merge branch 'trunk' into feat_better_configs

429abf7

bengioe requested review from bearnshaw and aebrer June 6, 2023 18:55

bengioe added 4 commits June 6, 2023 14:58

tox

0bb940d

re-fix deps

decaa68

minor fixes for seh_frag_moo

927eff3

tox

955896e

bearnshaw reviewed Jun 12, 2023

View reviewed changes

pyproject.toml Outdated Show resolved Hide resolved

src/gflownet/utils/metrics.py Outdated Show resolved Hide resolved

tests/test_frag_env.py Outdated Show resolved Hide resolved

bengioe mentioned this pull request Jun 13, 2023

Convert configs to standard library #95

Closed

bengioe added 4 commits June 14, 2023 14:36

switch to OmegaConf

c10b35b

switch to omegaconf

5050749

fix pre-commit-config

c5a4a46

add omegaconf dep

67cccdb

bengioe added 4 commits July 4, 2023 11:49

fix list defaults to fields

da89047

remove comment

8f73601

Merge branch 'trunk' into feat_better_configs

3f1bf89

version change and revert unnecessary torch.tensor call

f47ae32

bengioe removed the request for review from aebrer July 11, 2023 13:44

maclandrol reviewed Jul 17, 2023

View reviewed changes

hadim approved these changes Jul 17, 2023

View reviewed changes

addressing PR comments

0d5ba3c

bengioe merged commit ffabcfd into trunk Jul 18, 2023
6 checks passed

bengioe deleted the feat_better_configs branch July 18, 2023 19:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature: better configs #93

Feature: better configs #93

bengioe commented Jun 6, 2023 •

edited

Loading

maclandrol left a comment

hadim left a comment

Feature: better configs #93

Feature: better configs #93

Conversation

bengioe commented Jun 6, 2023 • edited Loading

maclandrol left a comment

Choose a reason for hiding this comment

hadim left a comment

Choose a reason for hiding this comment

bengioe commented Jun 6, 2023 •

edited

Loading