New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update starburst-galaxy-quickstart.yaml #196
Update starburst-galaxy-quickstart.yaml #196
Conversation
Add additional leading "*" on line red-hat-data-services#66 to bold the "TRINO_PASSWORD" text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@bdattoma Would you like to review these changes? I have approved the PR. |
I think this PR already takes care of it, but I am unsure of how the dashboard handles formatting so I just wanted to point out that in the current version the underscores are missing from the variable names, and they are instead formatted in italics, like TRINOUSERNAME |
@taneem-ibrahim I've tried these changes on local and it confirmed what @lugi0 said. The underscore needs to be escaped like this The starburst sample notebook expects to receive |
@starburst-blumbert you could try in this way:
|
Made "JupyterHub" bold on line red-hat-data-services#63 for consistency with other instructions. Added escape characters ("\") on line 66 for the Trino environment variables so that they display properly. Removed the additional "your" that was on line 84. Shortened line 99 to remove the comment about Python code and running models in Jupyter.
Thank you for the tips @bdattoma ! I have made the updates to the environment variable names as suggested along with a couple of other minor cosmetic issues I found when previewing this asset. Please let me know if there is anything else that needs correcting. |
Added in a new line (red-hat-data-services#84) to provide instructions for downloading the Jupyter notebook. Updated step numbers for lines 85 - 88 accordingly since a new step 1 was added.
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Add additional leading "*" on line #66 to bold the "TRINO_PASSWORD" text.
[UPSTREAM]
has been prepended to the commit message