Fix retrieving OAuthClient Resource

[VaishnaviHire]

This PR fixes the OAuthClient deletion issue. Note that this only happens in downstream Operator

Root Cause

• Downstream operator only watches 4 namespaces: https://github.com/red-hat-data-services/opendatahub-operator/blob/master/cmd/manager/main.go#L92
• The controller-runtime package doesn't allow Get calls for ClusterScoped resources, if only limited namespaces are being watched by the controller. (Multi Namespace Cache doesn't support Get for cluster scoped resources kubernetes-sigs/controller-runtime#934)
• This has been fixed in controller-runtime v0.8.3, however we cannot update the package due to dependencies on other packages(need to update operator-sdk)

Fix

• This commit moves all Get calls for OAuthClient to List
• Adds function to update OAuthClient resource incase there is a Stale object.

Testing Steps

This can be tested without Uninstallation as follows -

• Install RHODS instance

   ./setup.sh quay.io/modh/rhods-operator-live-catalog:1.19.0-rhods-5836
  

• Delete rhods-dashboard KfDef (wait for deletion to complete)

  oc delete kfdef rhods-dashboard -n redhat-ods-applications
  

• Verify OAuthClient is deleted

  oc get oauthclient/dashboard-oauth-client 
  

• To Verify OAuthClient update, create a dummy resource

  apiVersion: oauth.openshift.io/v1
  grantMethod: auto
  kind: OAuthClient
  metadata:
   name: dashboard-oauth-client
  secret: Zs6i7Q2AEjnHErMoxsjBSBmoyOD8Bwgd
  

• Now re-create rhods-dashboard KfDef. The dashboard-oauth-client resource should be updated with latest secret.

Merge criteria:

• The commits are squashed in a cohesive manner and have meaningful messages.
• For commits that came from upstream, [UPSTREAM] has been prepended to the commit message.
• JIRA link(s): https://issues.redhat.com/browse/RHODS-5836
• The Jira story is acked.
• Live build image:
• Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
• The developer has manually tested the changes and verified that the changes work

[VaishnaviHire]

/retest

[openshift-ci]

@VaishnaviHire: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/ci-index	b639f46	link	true	/test ci-index
ci/prow/48-ci-index	b639f46	link	true	/test 48-ci-index
ci/prow/modh-operator-e2e	b639f46	link	false	/test modh-operator-e2e
ci/prow/images	b639f46	link	true	/test images
ci/prow/48-modh-operator-e2e-48	b639f46	link	false	/test 48-modh-operator-e2e-48
ci/prow/48-images	b639f46	link	true	/test 48-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[VaishnaviHire]

/retest

[openshift-ci]

@VaishnaviHire: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

• /test 48-ci-index
• /test 48-images
• /test 48-modh-unit-tests-48
• /test ci-index
• /test images
• /test modh-unit-tests

The following commands are available to trigger optional jobs:

• /test 48-modh-operator-e2e-48
• /test modh-operator-e2e

Use /test all to run all jobs.

In response to this:

/retest aicoe-ci/build-check

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[samuelvl]

/lgtm

I confirm the oauthclient is removed after the dashboard KfDef is removed:

# OAuthClient exists
$ oc get oauthclient/dashboard-oauth-client 
NAME                     SECRET                             WWW-CHALLENGE   TOKEN-MAX-AGE   REDIRECT URIS
dashboard-oauth-client   es8XWimVObrTMwFJS6px0LOz8GNlHW32   false           default         https://rhods-dashboard-redhat-ods-applications.apps.samuvl.dev.datahub.redhat.com

# Delete KfDef
$ oc delete kfdef rhods-dashboard -n redhat-ods-applications
kfdef.kfdef.apps.kubeflow.org "rhods-dashboard" deleted

# OAuthClient is removed
$ oc get oauthclient/dashboard-oauth-client                 
Error from server (NotFound): oauthclients.oauth.openshift.io "dashboard-oauth-client" not found

[Jooho]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jooho, samuelvl, VaishnaviHire

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [VaishnaviHire,samuelvl]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment