Add support for build manifests from different location in Dockerfile #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zdtsw
changed the title
|
/hold Should not cherry-pick if its merge in upstream. |
this changes include 2 parts:
we can have 1st part in the upstream and sync down to RHODS, |
1 task
zdtsw
force-pushed
the
issue/424_2
branch
2 times, most recently
from
918c315
to
76553ff
Compare
5 tasks
- fetch manifests from component repo - componnets cannot fetch from component repo, then from odh-manifests - use red-hat-data-services for git org in script - since odh-modelmesh-controller is moved out from model-mesh need copy - kserve does not have 'base' folder in component repo, change path ref: https://github.com/opendatahub-io/odh-manifests/blob/master/kserve/hack/kustomization.yaml Signed-off-by: Wen Zhou <wenzhou@redhat.com>
|
we will still need the change in not only sync from ODH @VaishnaviHire after that, changes should be fine to sync. but have this PR hold, still upstream is merged and incubation for a bit time |
|
close this one, will use "monitroing-intergration" to get all out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component manifests from component repo
componnet does not sync from component repo will still be from odh-manifests
refer midstream https://gitlab.cee.redhat.com/data-hub/rhods-cpaas-midstream/-/merge_requests/1067
ref: opendatahub-io#357
rebase after API change, test:
Test:
local image: quay.io/wenzhou/opendatahub-operator-catalog:v2.8.424-2
when enable all component
has no problem to start pods.