Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move RHODS ods-manifests to rhods-operator/config #52

Merged

Conversation

zdtsw
Copy link

@zdtsw zdtsw commented Sep 11, 2023

  • move RHODS ods-manifests/monitoring to rhods-operator/config/monitoring
  •   move ods-manifests/partners/anaconda to rhods-oeprator/config/partner
    
  •   to create config/monitoring/components for prometheus configmap
    

eventually, we will remove these from odh-manifests.

Ref: opendatahub-io#357

related to #43

@zdtsw
Copy link
Author

zdtsw commented Sep 22, 2023

as we discussed, only to copy from RHODS odh-manifests into RHODS rhods-operator
then we will split it into component based alerts if SRE agree on that approach.

- RHODS ods-manifests/monitoring to rhods-operator/config/monitoring
- ods-manifests/partners/anaconda to rhods-oeprator/config/partner
- create config/monitoring/prometheus/components
- split configs into  component based prometheus rules
- update monitoring.go

Signed-off-by: Wen Zhou <wenzhou@redhat.com>
@zdtsw zdtsw marked this pull request as draft September 26, 2023 16:07
@zdtsw zdtsw changed the base branch from main to monitoring-integration September 27, 2023 06:49
@zdtsw zdtsw removed the request for review from VaishnaviHire September 27, 2023 07:08
@zdtsw zdtsw marked this pull request as ready for review September 27, 2023 07:08
@zdtsw zdtsw merged commit e606b6a into red-hat-data-services:monitoring-integration Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant