pytest run fails on Defining 'pytest_plugins' in a non-top-level conftest is no longer supported

[mbukatov]

Pytest run fails on Defining 'pytest_plugins' in a non-top-level conftest is no longer supported:

(venv) [ocsqe@localhost ocs-ci]$ python -m pytest -m deployment --cluster-name mbukatov-ocsqe                                                                 
==================================================================== test session starts =====================================================================
platform linux -- Python 3.7.3, pytest-4.5.0, py-1.8.0, pluggy-0.11.0 -- /home/ocsqe/projects/ocs-ci/venv/bin/python                                          
cachedir: .pytest_cache                                                                                                                                       
rootdir: /home/ocsqe/projects/ocs-ci, inifile: pytest.ini                                                                                                     
plugins: ocs-ci-0.1                                                                                                                                           
collected 0 items / 1 errors                                                                                                                                  
                                                                                                                                                              
=========================================================================== ERRORS ===========================================================================
_______________________________________________________________ ERROR collecting test session ________________________________________________________________
Defining 'pytest_plugins' in a non-top-level conftest is no longer supported because it affects the entire directory tree in a non-explicit way.              
  /home/ocsqe/projects/ocs-ci/unittests/conftest.py                                                                                                           
Please move it to a top level conftest file at the rootdir:                                                                                                   
  /home/ocsqe/projects/ocs-ci                                                                                                                                 
For more information, visit:                                                                                                                                  
  https://docs.pytest.org/en/latest/deprecations.html#pytest-plugins-in-non-top-level-conftest-files                                                          
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
================================================================== 1 error in 0.14 seconds ===================================================================
(venv) [ocsqe@localhost ocs-ci]$

This is happening because main pytest run is collecting tests from unittests directory.

[RazTamir]

Is this blocking only deployment?
I just managed to execute tier 1 without issues

[mbukatov]

@RazTamir it happens during collecting phase, it will affect any tests. The problem is visible since merge of #104, which was merged just few hours ago.

Edit: as Petr points out below, if you specify at least tests directory, pytest will collect test cases only there and you won't hit this.

[petr-balogh]

@mbukatov I see you didn't defined the folder of tests in you command so pytest is taking the ./ as default I think so than it's trying to collect everything under the path. So I think that user have to define the ./tests folder when running pytest to provide the path of tests where we have our tests.

So if you will run
py.test -m deployment --cluster-name mbukatov-ocsqe ./tests do you still see the issue?

[mbukatov]

@mbukatov I see you didn't defined the folder of tests in you command so pytest is taking the ./ as default I think so than it's trying to collect everything under the path. So I think that user have to define the ./tests folder when running pytest to provide the path of tests where we have our tests.

You are right that pytest is trying to collect everything in the current directory. That said, making boundaries between unittests and actual tests explicit is a good idea, and I just forgot to make sure it's enforced.

[petr-balogh]

@mbukatov what do you propose to fix this? I see that boundaries are already defined in different folders which we documented should be used to run with. I think that it's normal from user to have specified test directory/path to be defined.

[mbukatov]

@mbukatov what do you propose to fix this?

#109

I see that boundaries are already defined in different folders which we documented should be used to run with. I think that it's normal from user to have specified test directory/path to be defined.

Correct. It will just make pytest more resilient to such errors, esp. for deployment.

[mbukatov]

Fixed by #109