Initial support for unit tests of pytest plugins #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One can pass pytest options for unit test run, eg: $ tox -- unittests -v --pdb Which can be helpful during debugging.
There is no reason to have __init__.py in the root directory of the repository.
|
@RazTamir understood, I will polish it so that it could be merged asap, without adding the tests I originally intended to write. |
That said, the original indentation was valid from PEP8's point of view.
mbukatov
changed the title
petr-balogh
approved these changes
May 28, 2019
RazTamir
approved these changes
May 28, 2019
In this case we can consider the output from travis (tox) as verification: https://travis-ci.org/red-hat-storage/ocs-ci/jobs/538111788 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests introduces unit tests of our pytest plugins, tested via pytest via pytester, which is official pytest module for testing pytest plugins via pytest.
It contains few simple test cases only, so that it's possible to add unit tests for config and cli option processing later.
Don't squash this pull request into single commit when merging, each commit message is meaningful.