New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ocs-to-ocs: list within namespace #1516
ocs-to-ocs: list within namespace #1516
Conversation
@nb-ohad @kesavanvt ^^^ |
8e5fb7f
to
8f3204b
Compare
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add permissions for the node, we do not have permissions for it as of now.
https://github.com/red-hat-storage/ocs-operator/blob/main/rbac/provider-role.yaml
/cherry-pick release-4.10 |
@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
dfc86bd
to
6045e1e
Compare
add RBAC for nodes to the provider rbacs Signed-off-by: subhamkrai <srai@redhat.com>
list storageConsumerList and node ip within namespace. Closes: red-hat-storage#1514 Signed-off-by: subhamkrai <srai@redhat.com>
6045e1e
to
6f0cd5f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, nb-ohad, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@subhamkrai: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@agarwal-mudit: new pull request created: #1517 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
list storageConsumerList and node ip within namespace
Closes: #1514
Signed-off-by: subhamkrai srai@redhat.com