Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocs-to-ocs: list within namespace #1516

Merged

Conversation

subhamkrai
Copy link
Contributor

@subhamkrai subhamkrai commented Feb 14, 2022

list storageConsumerList and node ip within namespace

Closes: #1514
Signed-off-by: subhamkrai srai@redhat.com

@subhamkrai
Copy link
Contributor Author

@nb-ohad @kesavanvt ^^^

@subhamkrai subhamkrai changed the title ocs-to-ocs: list storageConsumerList within namespace ocs-to-ocs: list within namespace Feb 14, 2022
@nb-ohad
Copy link
Contributor

nb-ohad commented Feb 14, 2022

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2022
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add permissions for the node, we do not have permissions for it as of now.

https://github.com/red-hat-storage/ocs-operator/blob/main/rbac/provider-role.yaml

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@agarwal-mudit
Copy link
Member

/cherry-pick release-4.10

@openshift-cherrypick-robot

@agarwal-mudit: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@subhamkrai subhamkrai force-pushed the fix-list-ocs-to-ocs branch 5 times, most recently from dfc86bd to 6045e1e Compare February 14, 2022 10:23
add RBAC for nodes to the provider rbacs

Signed-off-by: subhamkrai <srai@redhat.com>
list storageConsumerList and node ip within namespace.

Closes: red-hat-storage#1514
Signed-off-by: subhamkrai <srai@redhat.com>
Copy link
Member

@iamniting iamniting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2022
@nb-ohad
Copy link
Contributor

nb-ohad commented Feb 14, 2022

/lgtm

@nb-ohad
Copy link
Contributor

nb-ohad commented Feb 14, 2022

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, nb-ohad, subhamkrai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 14, 2022

@subhamkrai: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 6f0cd5f link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit cef8132 into red-hat-storage:main Feb 14, 2022
@openshift-cherrypick-robot

@agarwal-mudit: new pull request created: #1517

In response to this:

/cherry-pick release-4.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider/Consumer: Provider API server crashloopbackoff
6 participants