Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2054147:[release-4.10] controllers: Do not list node in the namespace #1520

Merged
merged 2 commits into from Feb 15, 2022
Merged

Bug 2054147:[release-4.10] controllers: Do not list node in the namespace #1520

merged 2 commits into from Feb 15, 2022

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #1519

/assign iamniting

@iamniting
controllers: Do not list node in the namespace
44669ae 
Nodes are cluster scoped resources and should not be listed within
the namespace.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@iamniting
Revert "ocs-to-ocs: add RBAC for nodes to the provider rbacs"
7393cfa 
This reverts commit 4d95071.

Nodes permission is not required for a provider server.

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Feb 15, 2022
Merged
@agarwal-mudit
Copy link
Member

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/red-hat-storage-ocs-ci-e2e-aws 7393cfa link false /test red-hat-storage-ocs-ci-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@agarwal-mudit
Copy link
Member

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@iamniting iamniting changed the title [release-4.10] controllers: Do not list node in the namespace Bug 2054147:[release-4.10] controllers: Do not list node in the namespace Feb 15, 2022
@openshift-ci openshift-ci bot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2054147, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2054147:[release-4.10] controllers: Do not list node in the namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 15, 2022
@iamniting
Copy link
Member

/bugzilla refresh

@openshift-ci openshift-ci bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@iamniting: This pull request references Bugzilla bug 2054147, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.10.0) matches configured target release for branch (ODF 4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebondare@redhat.com), skipping review request.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Feb 15, 2022
@agarwal-mudit
Copy link
Member

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agarwal-mudit, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@openshift-merge-robot openshift-merge-robot merged commit 527e036 into red-hat-storage:release-4.10 Feb 15, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 15, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2054147 has been moved to the MODIFIED state.

In response to this:

Bug 2054147:[release-4.10] controllers: Do not list node in the namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@iamniting iamniting

@agarwal-mudit agarwal-mudit

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@openshift-cherrypick-robot @agarwal-mudit @iamniting @openshift-merge-robot