controllers: Do not list node in the namespace #1519
Conversation
Nodes are cluster scoped resources and should not be listed within the namespace. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
This reverts commit 4d95071. Nodes permission is not required for a provider server. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
/cherry-pick release-4.10 |
|
@iamniting: once the present PR merges, I will cherry-pick it on top of release-4.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@subhamkrai: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, iamniting, subhamkrai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
@iamniting: new pull request created: #1520 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Nodes are cluster scoped resources and should not be listed within
the namespace.
Signed-off-by: Nitin Goyal nigoyal@redhat.com