Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add prometheus rules verification in CI #2061

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add prometheus rules verification in CI #2061

wants to merge 2 commits into from

Conversation

weirdwiz
Copy link
Contributor

This pull request does the following:

  • Adds a new GitHub Actions workflow that verifies the latest Prometheus rules YAML files when changes occur in the metrics/* directory.
  • Modifies the Makefile to include a new target 'verify-latest-prometheus-rules-yamls', which triggers the verification script.
  • Creates a new script 'verify-latest-prometheus-rules-yamls.sh' in the hack directory. This script checks for uncommitted changes in the Prometheus rules files and prints a success message when no out-of-tree changes are found.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weirdwiz
Once this PR has been reviewed and has the lgtm label, please assign jarrpa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@weirdwiz
Copy link
Contributor Author

weirdwiz commented May 26, 2023 •
edited

PTAL @umangachapagain

@weirdwiz weirdwiz mentioned this pull request May 26, 2023
Merged
@weirdwiz
Add prometheus rules verification in CI
0234a93 
This commit does the following:

- Adds a new GitHub Actions workflow that verifies the latest Prometheus rules YAML files when changes occur in the metrics/* directory.
- Modifies the Makefile to include a new target 'verify-latest-prometheus-rules-yamls', which triggers the verification script.
- Creates a new script 'verify-latest-prometheus-rules-yamls.sh' in the hack directory. This script checks for uncommitted changes in the Prometheus rules files and prints a success message when no out-of-tree changes are found.

Signed-off-by: Divyansh Kamboj <dkamboj@redhat.com>
malayparida2000
malayparida2000 reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weirdwiz changes look good to me. Please fix the failing DCO test also.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 17, 2023

@weirdwiz: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocs-operator-bundle-e2e-aws bffbd00 link true /test ocs-operator-bundle-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 5, 2024
@openshift-merge-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malayparida2000 malayparida2000 malayparida2000 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@weirdwiz @openshift-merge-robot @malayparida2000