Height of text face not adjusting to wrapped text.

[fergus4]

When text face induces wrap due to length exceeding text face width, height is not adjusted to accommodate the wrapped text below and text is cut off.

Example:

view [
	size 100x300
	text 100 "sdsad sadsad  fghgfh gerr nghn fsdfsd fghfgh sfsdf"
	return
	text 100x100 "sdsad sadsad  fghgfh gerr nghn fsdfsd fghfgh sfsdf"
]

In rebol text face height will adjust to accommodate all the wrapped text.

Windows 10
All others not tested

Red 0.6.4 for Windows built 13-Apr-2019/2:27:16-04:00 commit #fb18d4e

[bitbegin]

some limits with "GdipMeasureString"

Duplicate of #3760

[bitbegin]

Duplicate of #2757

[bitbegin]

temp solution bitbegin@13d0409

[hiiamboris]

1. mentioned issues are not duplicates as they contain explicit lines, while this issue is about word wrapped text
2. I don't think text face should be wrapped without the wrap flag, while it is - and I do consider this a bug: view [text 100x100 "sdsad sadsad fghgfh gerr nghn fsdfsd fghfgh sfsdf"]:
   
3. GdipMeasureString has nothing to do with this issue. The issue is in calc-size calling size-text on a face that is not yet created and which handle is zero. get-text-size replaces zero with the handle of desktop window and ` uses width & height of desktop window:

   red/modules/view/backends/windows/gui.reds

   Lines 298 to 300 in 3c68ef1

   	if null? hwnd [
   	hwnd: GetDesktopWindow
   	]

   red/modules/view/backends/windows/gui.reds

   Line 306 in 3c68ef1

   GetClientRect hWnd rc

size-text is an unbelievable mess: it calls gui/get-text-size, which calls base/render-text (what base has to do with other faces text size??), which in turn calls base/update-base-text, which calls GdipMeasureString. Root problem is the complexity of this twisted chain of calls as it cries for refactoring ;)

But a more immediate solution might be in passing planned face dimensions down the rabbit hole into render-text (which currently uses GetClientRect to obtain these).

[hiiamboris]

See also #4557

[qtxie]

size-text is an unbelievable mess: it calls gui/get-text-size, which calls base/render-text (what base has to do with other faces text size??), which in turn calls base/update-base-text, which calls GdipMeasureString.

That's @hiiamboris who wrote the code...
0f549f9#diff-f2e387060e079bd2b85d2637577a5538c9403cd7b7ad089d44461958938bf638R290

[hiiamboris]

Don't give me too much credit, I only replaced GDI measurement with GDI+ one.

[qtxie]

Root problem is that we mix GDI, GDI+ and D2D together. The initial version only use GDI and just one get-text-size call, no this twisted chain of calls. I think now we can get rid of GDI+. GDI is still needed as we use native control.

[dockimbel]

What View/Draw features would we loose if we drop GDI+?

[hiiamboris]

GDI has no wrapping for it's text label at all IIRC.

[qtxie]

What View/Draw features would we loose if we drop GDI+?

Nothing as we use D2D now.

GDI has no wrapping for it's text label at all IIRC.

Yes. That's the limitation of it. Working around it results in complex code. The native controls use GDI to draw the text. If we use GDI+ or D2D APIs to measure it, we'll get slightly different result. Which will cause other issues.

[hiiamboris]

I mean the reason we can write base wrap or text wrap in VID is because we're using GDI+ for their text. Or we could use D2D, but then @qtxie says it's heavy.

[qtxie]

I mean the reason we can write base wrap or text wrap in VID is because we're using GDI+ for their text. Or we could use D2D, but then @qtxie says it's heavy.

Use D2D for base face, yes, we already use it. I always has no problem with heavy solution. But I'm sure someone will do some benchmarks and complain about it later. For text face, see my note above. The native controls use GDI to draw the text. If we use GDI+ or D2D APIs to measure it, we'll get slightly different result. Which will cause other issues. We'll open a worm box by working around it.

[hiiamboris]

Are you using D2D for text face too then? It can't be GDI, since it supports wrapping.